Repository navigation
Fix release pipeline tests and workflow - #64831
Merged
Jake Bailey (jakebailey) merged 2 commits intoOct 15, 2026
Merged
Conversation
Jake Bailey (jakebailey)
commented
Oct 15, 2026
Jake Bailey (jakebailey)
commented
Member
- The version swap breaks a help test; fix it
- The token perms requested were not enough, and had odd errors on pipeline failure.
Release version bumps change the help header's padding even after its version text is normalized. This makes release creation fail solely because the new version has a different length. Keep normalized headers aligned so development and release versions can share the same baseline.
Failures before token creation leave the result-reporting action without a token, preventing the bot from explaining what went wrong. Three of the workflows also omit the issue permission needed to post results. Allow reporting authentication after earlier failures without allowing branch pushes or PR creation to proceed on failure.
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Oct 15, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes include regression coverage, and no blocking issues were identified.
0 open findings
What changed in this PR
Fixes release pipeline failures by stabilizing compiler help baselines across version changes and correcting workflow authentication.
Changes:
- Preserve help-header padding when sanitizing version strings.
- Add regression tests and update the help baseline.
- Allow authentication after earlier workflow failures and grant issue-write permissions where needed.
| File | Description |
|---|---|
tsc/testdata/baselines/reference/tsc/commandLine/show-help-with-ExitStatus.DiagnosticsPresent_OutputsSkipped.js |
Update expected header padding. |
tsc/internal/execute/tsctests/tsc_test.go |
Test localized version replacement and padding. |
tsc/internal/execute/tsctests/sys.go |
Preserve padded width during version sanitization. |
.github/workflows/sync-branch.yaml |
Adjust authentication conditions and issue permissions. |
.github/workflows/set-version.yaml |
Adjust authentication conditions and issue permissions. |
.github/workflows/new-release-branch.yaml |
Adjust authentication conditions and issue permissions. |
.github/workflows/create-cherry-pick-pr.yml |
Allow authentication after earlier failures. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.