Expose labeled tuple element declarations in the TypeScript 7 API - #64109
Merged
Andrew Branch (andrewbranch) merged 3 commits intoAug 31, 2026
Merged
Conversation
1 task
Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing labeledElementDeclarations in TypeScript 7
Expose labeled tuple element declarations in the TypeScript 7 API
Aug 31, 2026
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Aug 31, 2026
Andrew Branch (andrewbranch)
marked this pull request as ready for review
August 31, 2026 22:57
Andrew Branch (andrewbranch)
approved these changes
Aug 31, 2026
Andrew Branch (andrewbranch)
enabled auto-merge
August 31, 2026 22:58
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
August 31, 2026 22:58
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes tuple label declarations through the TypeScript 7 API.
Changes:
- Serializes tuple-label node handles, preserving sparse entries.
- Adds async and sync API properties and hydration.
- Tests named tuple-member resolution.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/api/session.go |
Creates label node handles. |
tsc/internal/api/proto.go |
Adds protocol field. |
packages/typescript/src/api/proto.generated.ts |
Updates generated protocol types. |
packages/typescript/src/api/sync/types.ts |
Adds sync public property. |
packages/typescript/src/api/sync/api.ts |
Hydrates sync node handles. |
packages/typescript/test/sync/api.test.ts |
Tests sync label resolution. |
packages/typescript/src/api/async/types.ts |
Adds async public property. |
packages/typescript/src/api/async/api.ts |
Hydrates async node handles. |
packages/typescript/test/async/api.test.ts |
Tests async label resolution. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+220
to
+223
| if resp.LabeledElementDeclarations == nil { | ||
| resp.LabeledElementDeclarations = make([]NodeHandle, len(elementInfos)) | ||
| } | ||
| resp.LabeledElementDeclarations[i] = sd.nodeHandleFrom(declaration) |
Andrew Branch (andrewbranch)
deleted the
copilot/fix-labeled-element-declarations
branch
August 31, 2026 23:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 7 did not expose tuple element labels through
TupleType, preventing API consumers from recoveringfooandbarfrom:API
TupleType.labeledElementDeclarations.NodeHandle<NamedTupleMember | ParameterDeclaration>values.Protocol
Coverage