Repository navigation
fix(microskills): guard parse_payload against wrongly-typed proposer fields - #198
Open
Tejas Lamba (TejasLamba2006) wants to merge 1 commit into
Open
Tejas Lamba (TejasLamba2006) wants to merge 1 commit into
Tejas Lamba (TejasLamba2006) wants to merge 1 commit into
Conversation
…fields - Handle extractors/facts as null (not just missing key) - Filter extractors with non-string pattern - Filter facts with non-dict detector - Guard _rx against non-string pattern input Fixes microsoft#173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the proposer returns wrongly-typed fields,
parse_payloadcrashes instead of filtering them out, causing the session to stay pending and retry the proposer on every session start.Changes
obj.get("extractors", [])returnsNone(not[]) when the key exists with valuenull. Changed toobj.get("extractors") or []patternfielddetectorfield_rx()against non-string inputTest plan
Inline verification:
Fixes #173