fix: merging dev to main - #712
Merged
Merged
Conversation
fix: normalize search query to lowercase and update image assets
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The code change is small and low-risk, with only a minor PR-metadata mismatch noted.
Pull request overview
This PR updates the backend document-search flow to normalize the incoming query string to lowercase before calling KernelMemory search, aiming to make searches more consistent with respect to casing.
Changes:
- Normalize
queryviaToLowerInvariant()before invoking_memoryWebClient.SearchAsync(...). - Minor whitespace/formatting adjustment around the search call.
File summaries
| File | Description |
|---|---|
| App/backend-api/Microsoft.GS.DPS/API/UserInterface/Documents.cs | Lowercases the document search query prior to KernelMemory search execution. |
Review details
- Files reviewed: 1/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Roopan-Microsoft
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a minor improvement to the document search functionality by normalizing the search query to lowercase before performing the search. This helps ensure that searches are case-insensitive and more consistent.
Documents.cs, thequerystring is now converted to lowercase usingToLowerInvariant()before being passed to the search client, ensuring case-insensitive searches.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information