fix: normalize search query to lowercase and update image assets - #709
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new unconditional lowercasing of the search query can alter semantic search behavior (embedding input) and should be revised to avoid changing query meaning.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adjusts the backend document search flow to normalize the incoming search query (currently by lowercasing it) before calling Kernel Memory search, aiming to make search behavior more consistent.
Changes:
- Normalize the
querystring inGetAllDocumentsByPageAsyncprior to_memoryWebClient.SearchAsync(...). - Minor whitespace/formatting adjustment around the query handling block.
File summaries
| File | Description |
|---|---|
| App/backend-api/Microsoft.GS.DPS/API/UserInterface/Documents.cs | Normalizes the search query before invoking Kernel Memory search, affecting how document IDs are retrieved for paging. |
Review details
- Files reviewed: 1/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The PR title/description indicates image asset updates, but the provided diff only changes query normalization, suggesting the PR scope/description may be inconsistent or incomplete.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/4 changed files
- Comments generated: 1
- Review effort level: Lite
Purpose
Normalize search query to lowercase and update image according to gpt model used
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information