Fix polymiddleware error should not propagate to React runtime#5833
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents error box polymiddleware “fallthrough” warnings/errors from propagating into the React runtime when <DebugProvider> is not mounted, by adding a null-rendering catchall fallback and an HTML2 regression test.
Changes:
- Added a
NullComponentcatchall fallback toErrorBoxPolymiddlewareProxyand touseBuildRenderErrorBoxCallback()-built render callbacks. - Added an HTML2 test to validate Adaptive Cards render failures don’t produce the RCoR fallthrough warning when
<DebugProvider>is absent. - Added a changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/api-middleware/src/errorBoxPolymiddleware.tsx | Adds a null fallback catchall for error box proxy and the render-callback builder hook to avoid RCoR fallthrough surfacing to React runtime. |
| tests/html2/adaptiveCard/renderError.withoutDebug.html | Adds regression coverage for rendering a failing Adaptive Card without <DebugProvider>. |
| CHANGELOG.md | Documents the fix in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OEvgeny
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
<DebugProvider>is not mounted, by @compulim, in PR #5833Description
<ErrorBoxPolymiddlewareProxy>anduseBuildRenderErrorBoxCallbackshould have "catchall". Without<DebugProvider>, rendering those component should not throw.Design
Specific Changes
<DebugProvider>or any error box polymiddleware is not addedCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)