Bug 634953: Fix factbox drilldowns for finished production orders

[ChethanT]

Summary

• Bug: Subcontracting factbox drilldowns in Purchase Order and Transfer Order break after the linked production order is finished.
• Root cause: \Subc. ProdO. Factbox Mgmt.\ (CU 99001559) hardcodes \SetRange(Status, ::Released)\ in all 5 procedures, so no data is returned once status moves to Finished.
• Fix: Replace \SetRange(Status, ::Released)\ with \SetFilter(Status, '>=%1', ::Released)\ across all filter procedures so that both Released and Finished production orders are found. \ShowProductionOrder\ now opens the correct page (\Released Production Order\ or \Finished Production Order) based on the resolved status.

Changes

• \SubcProdOFactboxMgmt.Codeunit.al\ — Fixed all 5 affected procedures
• \SubcSubcontractingTest.Codeunit.al\ — Added \ProdOFactboxMgmtShowsDataAfterProdOrderFinished\ test ([SCENARIO 634953])

Test

Added \ProdOFactboxMgmtShowsDataAfterProdOrderFinished\ in codeunit 139989 — verifies that \CalcNoOfProductionOrderRoutings\ and \CalcNoOfProductionOrderComponents\ return positive counts after the production order is finished.

Fixes AB#634953

🤖 Generated with GitHub Copilot

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Stale routing-line status used after failed FindFirst

When ProdOrderRoutingLine.FindFirst() returns false the record variable retains its default Status value (Simulated = 0). The immediately following ProdOrderComponent.SetRange(Status, ProdOrderRoutingLine.Status) then filters components by Simulated status, finding nothing and silently returning 0 components instead of the expected count.

Recommendation:

• Only set the component status filter when a routing line was actually found, or fall back to the production order's status otherwise. Alternatively, store the production order status and use it unconditionally for the component filter.

Suggested change

	ProdOrderComponent.SetRange(Status, ProdOrderRoutingLine.Status);
	if ProdOrderRoutingLine.FindFirst() then begin
	ProdOrderComponent.SetRange("Routing Link Code", ProdOrderRoutingLine."Routing Link Code");
	ProdOrderComponent.SetRange(Status, ProdOrderRoutingLine.Status);
	end else
	ProdOrderComponent.SetRange(Status, ProdOrderComponent.Status::Released);

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Case statement silently ignores unexpected status

The case ProductionOrder.Status of block handles only Released and Finished. Although the preceding SetFilter('>=%1', Released) makes other statuses theoretically unreachable today, any future enum addition or unexpected data would cause ShowProductionOrder to silently exit without opening any page, giving the user no feedback.

Recommendation:

• Add an else branch that either opens a generic fallback page or raises an informative error.

Suggested change

	case ProductionOrder.Status of
	else
	Error('Unexpected production order status: %1', ProductionOrder.Status);

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}