Skip to content

Fix AA0237 violations to enable CodeCop rules AA0073 and AA0237 as errors#7410

Open
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-rules-failures
Open

Fix AA0237 violations to enable CodeCop rules AA0073 and AA0237 as errors#7410
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-rules-failures

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

Fixes the build failures that block merging PR #7402, which re-enables CodeCop rules AA0073 and AA0237 as Error. All 94 violations were AA0237: record variables named with a Temp prefix but not declared temporary.

Changes

  • src/rulesets/CodeCop.ruleset.json: Promote AA0073 and AA0237 from NoneError
  • 47 files in src/System Application/App/: Add temporary keyword to 94 record variable declarations that carried the Temp naming prefix without the matching modifier

Example fix

// Before
TempEmailAccounts: Record "Email Account";

// After
TempEmailAccounts: Record "Email Account" temporary;

Affected modules: Email, Security Groups, Performance Profiler, Permission Sets, Agent, SharePoint, Word Templates, MCP, User Settings, Guided Experience, Barcode, Extension Management, AppSource Gallery, Azure AD, and more.


⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

Copilot AI changed the title [WIP] Fix failures caused by enabling rules Fix AA0237 violations to enable CodeCop rules AA0073 and AA0237 as errors Mar 26, 2026
Copilot AI requested a review from SBalslev March 26, 2026 12:23
@Groenbech96 Groenbech96 marked this pull request as ready for review May 29, 2026 11:50
@Groenbech96 Groenbech96 requested review from a team as code owners May 29, 2026 11:50
@github-actions
Copy link
Copy Markdown
Contributor

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants