Repository navigation
feat(client): report checkout, write, header-wait and body-read phase timings - #15
Merged
Merged
Conversation
… timings Four new ClientEvent variants (the enum is non_exhaustive, so observers compile unchanged): - CheckoutCompleted: how long the pool took to hand out a connection (reused, newly connected with DNS and connect, or after waiting) - RequestWritten: writing the request head and body - ResponseHeadersReceived: from the request being written to the response head being read (server time plus network, as the client sees it) - ResponseBodyRead: reading the buffered response body Together with DnsCompleted and ConnectionCompleted an observer can now split a slow call into pool wait, connect, write, server wait and body read without per-request state on its side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four ClientEvent variants so an observer can split one call into its phases without keeping per-request state:
CheckoutCompleted { duration, reused, error }: the pool handing out a connection (reused, new including DNS and connect, or after a wait)RequestWritten { duration, error }: writing the request head and bodyResponseHeadersReceived { duration, error }: request written to response head read (server time plus network)ResponseBodyRead { duration, bytes, error }: the buffered body read (streaming bodies are read, and timed, by the caller)ClientEventis#[non_exhaustive], so existing observers compile unchanged. The recording observer used by the existing lifecycle tests ignores the new variants;observer_reports_request_phase_timingschecks their order on a new and a reused connection and that a slow server shows up as header wait, not write or body time.cargo test --features client --lib client::: 124 passed.