Skip to content

Commit 57dc28e

Browse files
authored
Fix a dangling pointer discovered by a fresh Clang (ros2#1222)
Fix a dangling pointer discovered by the -Wdangling Clang diagnostic: ``` rcl/src/rcl/node_resolve_name.c:95:26: error: temporary whose address is used as value of local variable 'error' will be destroyed at the end of the full-expression [-Werror,-Wdangling] 95 | const char * error = rmw_get_error_string().str; ``` Signed-off-by: Alexander Kornienko <alexfh@google.com>
1 parent cc72fc1 commit 57dc28e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

rcl/src/rcl/node_resolve_name.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ rcl_resolve_name(
9292
int validation_result;
9393
rmw_ret_t rmw_ret = rmw_validate_full_topic_name(remapped_topic_name, &validation_result, NULL);
9494
if (rmw_ret != RMW_RET_OK) {
95-
const char * error = rmw_get_error_string().str;
95+
rcutils_error_string_t error = rmw_get_error_string();
9696
rmw_reset_error();
97-
RCL_SET_ERROR_MSG(error);
97+
RCL_SET_ERROR_MSG(error.str);
9898
ret = RCL_RET_ERROR;
9999
goto cleanup;
100100
}

0 commit comments

Comments
 (0)