You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Contradictory specs: traverse() on a missing node throws vs returns [] #18
Two existing tests specify opposite behaviour for traversal from a missing node:
tests/unit/Database.test.ts:746: expect(() => db.traverse(99999)).toThrow('Start node with ID 99999 not found')
tests/unit/TraversalQuery.test.ts:735: db.traverse(99999).out('LINKS').toArray() should return []
Database.traverse has thrown since cc29cb8 (2025-10-27), so the second test fails on main. One of the two specs has to change; this needs an owner decision, not a code fix.
Ruled 2026-11-02 by @michaeloboyle: keep the error. db.traverse(missingId) throws Start node with ID <id> not found, as specified in tests/unit/Database.test.ts:746. The contradicting spec in tests/unit/TraversalQuery.test.ts now expects the same error (PR #19).
Activity
test: traverse() on a missing node throws (ruling on #18)
michaeloboyle commentedon Nov 2, 2026
Ruled 2026-11-02 by @michaeloboyle: keep the error.
db.traverse(missingId)throwsStart node with ID <id> not found, as specified intests/unit/Database.test.ts:746. The contradicting spec intests/unit/TraversalQuery.test.tsnow expects the same error (PR #19).