Skip to content

CI never fails: test step ends with || true #15

Closed

Description

@michaeloboyle

Problem

.github/workflows/ci.yml:35 runs the test step as:

npm run test:coverage -- --maxWorkers=1 --passWithNoTests || true

|| true means no test failure can fail CI. Run 32669557867 on main is marked success while its log reports:

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
FAIL tests/unit/TraversalQuery.test.ts
FAIL tests/integration/graph-operations.test.ts
Test Suites: 2 failed, 10 passed, 12 total
Time:        946.502 s

Fix

Remove || true. Expect CI to go red until the traversal termination bug is fixed (filed separately).

Benchmark report: 2026-11-02, Apple M2 Pro, Node 22, at a7f9ea7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingci-cdCI/CD and automation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions