Repository navigation
Treat an empty answer to a property read as no value - #179
Merged
Merged
Conversation
The node of a ComfoConnect Pro answers a property read with OK, but without a message. That decoded to an empty string or 0, so its node info would show firmware R0.0.0 and an empty serial number. A node that sends no value doesn't have the property, so raise a ComfoConnectRmiError then, like for a node that answers with an RMI error; get_node_info makes it None. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing for now: the empty answer was to the combined request, probably because the Pro lacks one of the properties, like a LAN C answers with an error. We'll see what the Pro answers to single reads (#171) first, and reopen this if it answers a missing property with an empty message too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
get_node_inforeading one property at a time (#171), a ComfoConnect Pro now tells about its own node (node 20, product 222), seen in discussion #55: nameComfoConnectPro, serial number, firmware R1.0.5, hardware version 1, product variant 0. But for the two properties it doesn't have, the model (0x08) and the article number (0x0B), it answers with result OK and no message, where a LAN C answers with an RMI error:That decoded to an empty string, so
list-nodesshowedmodel:and the model and article number of the Pro were""instead ofNone; a number would have become0. A node that sends no value doesn't have the property, soget_single_property(and soget_property) now raises aComfoConnectRmiErrorfor an empty message, like when a node answers with an RMI error.get_node_infomakes such a propertyNone, and raises when none of them has a value.This is also why the combined request in 0.4.4 got an empty answer from the Pro: it lacks one of the properties.
Testing
test_get_single_property_without_value(a number, a string and a version) andtest_get_node_info_of_node_without_values.list-nodesagainst a LAN C with a ComfoAir Q450 shows the same info for both nodes as before: no real property answers with an empty message there.🤖 Generated with Claude Code