Repository navigation
Describe how the bridge handles RPDO subscriptions - #174
Merged
Merged
Conversation
A subscription is identified by pdid and zone, the bridge accepts any pdid below 0x4000 and doesn't check the type, clients share subscriptions, and there is room for 192. The timeout is not used; the interval is in seconds, per client, rounded down to a power of 2, and only used by the LAN C. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
CnRpdoRequestsection ofdocs/PROTOCOL.md:pdidandzone. The bridge has no list of pdids: it accepts anypdidbelow16384(0x4000, higher getsNOT_EXIST) and never checks thetypeagainst thepdid.pdidandzoneshare one subscription, removed when the last one unsubscribes. Room for 192 subscriptions (NO_RESOURCESwhen full); unsubscribing from something that isn't subscribed getsNOT_EXIST.timeoutisn't used by the bridge.intervalis in seconds and kept per client: at most one notification per interval, rounded down to a power of 2 (10→ every 8 seconds). The LAN C (R1.5.1) does this; the gateway in a ComfoAir Flex (R1.2.1) ignores it.type) is described as fact instead of "the protobuf definition says".Documentation only.
🤖 Generated with Claude Code