Repository navigation
Fix the TIME and VERSION type ids, and add UINT64 and INT32 - #172
Merged
Merged
Conversation
TYPE_CN_TIME and TYPE_CN_VERSION were 0x10 and 0x11, but the type ids are 10 and 11 (0x0A and 0x0B), as the type table in PROTOCOL-PDO.md already says. Also add the two missing numeric types: 4 (CN_UINT64) and 7 (CN_INT32). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDO/property type ids run from 0 to 11.
TYPE_CN_TIMEandTYPE_CN_VERSIONwere defined as0x10and0x11, but they are 10 and 11 (0x0Aand0x0B), as the type table indocs/PROTOCOL-PDO.mdalready says. The bridge answers a subscription with type0x10/0x11with empty data. Nothing in the library subscribes with these types, so nothing was broken in practice.Also adds the two numeric types that were missing:
TYPE_CN_UINT64 = 0x04(8 bytes, unsigned)TYPE_CN_INT32 = 0x07(4 bytes, signed)Both are added to
NUMERIC_PROPERTY_TYPES, so they can be decoded and encoded, and to the type table indocs/PROTOCOL-PDO.md.Tests: a test that pins the type ids 0–11, and UINT64/INT32 cases in the encode, out-of-range, property decode and sensor signedness tests.
🤖 Generated with Claude Code