Repository navigation
users: keep list comments count in stats - #364
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
users -a statsdroppedlist_comments, the number of comments on the user's lists. Trakt already sends it. The contract adds it in trakt/trakt-api#1096, which is still open.Added
str.UserStatshasListComments(list_comments).Fixed
users -a statskeepslist_commentsin the export.Tests: the encode/decode round-trip test in
str/fails without the fix.Live check by the maintainer on 2026-11-19:
GET users/me/statsreturnedlist_comments: 0, andGET users/sean/statsreturnedlist_comments: 2. Both are kept in the export.AI: Claude Code compared the contract with the type and wrote the code, test and changelog entries.