Skip to content

Fix Sharp Library bottle folder affordance - #700

Merged
aaf2tbz merged 1 commit into
mainfrom
fix/sharp-library-open-bottle-folder
Oct 1, 2026
Merged

aaf2tbz merged 1 commit into
mainfrom
fix/sharp-library-open-bottle-folder

Conversation

@aaf2tbz

@aaf2tbz aaf2tbz commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replace the broken Sharp Library Add Asset flow with a working Tools → Open Folder action that opens the selected app's bottle prefix in Finder for manual file placement.

Changes

  • Remove the calls to the unimplemented asset picker and /sharp-library/add-asset endpoint.
  • Open the selected app's own bottle prefix and disable the action if no bottle is linked.
  • Document manual placement and keep managed runtime components on the runtime/bottle repair path.
  • Add a regression check for the action's bottle lookup and Finder wiring.

PR Readiness (MANDATORY)

  • Real-game launch test completed for game/runtime/graphics/compatibility changes (game + method below; otherwise mark N/A)
  • No hardcoded paths, secrets, or absolute /Users/... paths introduced
  • Config/rules TOML validated if configs/mtsp-rules.toml or DLL maps changed
  • Version metadata (CMakeLists.txt, app/src-c/Makefile, package.json, package-lock.json) in sync if version bumped
  • Bottle/runtime migration and launch behavior preserved (rollback plan noted if changed)
  • Docs / compatibility matrix updated for user-facing changes
  • Regression test added for each bug fix

Test notes

  • cd app && npm run build — passed (TypeScript and Vite production build).
  • node app/tests/sharp-library-open-bottle-folder.cjs — passed.
  • git diff --check — passed.
  • Real-game launch test: N/A; this change only opens the existing app bottle folder in Finder and does not alter launch/runtime behavior.

Risk

Low. The action uses the existing Finder bridge and bottle prefix path; rollback is reverting this commit. Managed runtime components remain governed by existing repair mechanisms.

@aaf2tbz
aaf2tbz merged commit 7d124dd into main Oct 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant