Skip to content

Fix native CI waitpid assertion - #693

Merged
aaf2tbz merged 1 commit into
mainfrom
fix/native-ci-child-reaping
Sep 29, 2026
Merged

aaf2tbz merged 1 commit into
mainfrom
fix/native-ci-child-reaping

Conversation

@aaf2tbz

@aaf2tbz aaf2tbz commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fix the C/C++/Obj-C CI failure in the runtime-routes test: the backend's process-wide SIGCHLD handler may reap a child before the test calls waitpid().

Changes

  • Retry the test's child wait on EINTR and accept ECHILD when the handler already reaped it.
  • Apply the helper to all three Wine-probe child waits in this test.

PR Readiness (MANDATORY)

  • No hardcoded paths, secrets, or absolute /Users/... paths introduced
  • Config/rules TOML validated if configs/mtsp-rules.toml or DLL maps changed
  • Version metadata (CMakeLists.txt, app/src-c/Makefile, package.json, package-lock.json) in sync if version bumped
  • Bottle/runtime migration and launch behavior preserved (rollback plan noted if changed)
  • Docs / compatibility matrix updated for user-facing changes
  • Regression test added for each bug fix

Validation

  • make -C app/src-c test
  • runtime-routes-test repeated five times
  • Pre-commit clang-format --dry-run --Werror passed

@aaf2tbz aaf2tbz changed the title Fix native CI child reaping assertion Fix native CI waitpid assertion Sep 29, 2026
@aaf2tbz
aaf2tbz merged commit 9f653ff into main Sep 29, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant