fix(setup): gate VC++ on Steam detection and consolidate dependency updates - #586
Merged
Conversation
Bumps [@vitejs/plugin-vue](https://github.com/vitejs/vite-plugin-vue/tree/HEAD/packages/plugin-vue) from 6.0.7 to 6.0.8. - [Release notes](https://github.com/vitejs/vite-plugin-vue/releases) - [Changelog](https://github.com/vitejs/vite-plugin-vue/blob/main/packages/plugin-vue/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-vue/commits/plugin-vue@6.0.8/packages/plugin-vue) --- updated-dependencies: - dependency-name: "@vitejs/plugin-vue" dependency-version: 6.0.8 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.5.8 to 2.5.10. - [Release notes](https://github.com/biomejs/biome/releases) - [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md) - [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.10/packages/@biomejs/biome) --- updated-dependencies: - dependency-name: "@biomejs/biome" dependency-version: 2.5.10 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@iconify-json/lucide](https://github.com/iconify/icon-sets) from 1.2.118 to 1.2.126. - [Commits](https://github.com/iconify/icon-sets/commits) --- updated-dependencies: - dependency-name: "@iconify-json/lucide" dependency-version: 1.2.126 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [electron](https://github.com/electron/electron) from 43.4.0 to 44.0.0. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v43.4.0...v44.0.0) --- updated-dependencies: - dependency-name: electron dependency-version: 44.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [marked](https://github.com/markedjs/marked) from 18.0.9 to 18.0.11. - [Release notes](https://github.com/markedjs/marked/releases) - [Commits](markedjs/marked@v18.0.9...v18.0.11) --- updated-dependencies: - dependency-name: marked dependency-version: 18.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
added 5 commits
September 8, 2026 16:02
# Conflicts: # app/package-lock.json # app/package.json
added 5 commits
September 8, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent setup from advancing to VC++ until Windows Steam is detected as installed and no installation is in progress.
Changes
Validation
node --test app/tests/setup-steam-gate.cjs: five tests pass.cd app && npm run build: passes.git diff --check: passes.Scope / risk
Setup renderer guard plus dependency updates; no C backend, application-version, Wine/graphics-payload, or migration changes. Electron is updated to major version 44 and needs desktop runtime testing. Fresh-install UI testing has not been performed. Revert this commit to restore the previous navigation behavior.
PR Readiness (MANDATORY)
/Users/...paths introducedconfigs/mtsp-rules.tomlor DLL maps changed — not changedCMakeLists.txt,app/src-c/Makefile,package.json,package-lock.json) in sync if version bumped — no version bumpChecklist exception rationale
Uses the existing
checklist-exceptionpolicy for the setup-navigation guard and consolidated dependency updates. Electron 44 has build/type validation but has not been tested interactively. No real-game compatibility or fresh-install manual validation is claimed; automated tests exercise blocked navigation, pending/duplicate clicks, positive detection, stale status, and request failure. No compatibility-matrix entry was added because graphics/game launch behavior is unchanged. The user-visible effect is documented in this PR summary. CI workflow requirements have not been modified.Consolidated Dependabot updates
Merged the five currently open Dependabot branches into this PR (not directly into main):
Resolved adjacent Electron/plugin-vue conflicts in both package manifests by retaining both updates.
npm ci, the five setup regression tests,npm run build,npx tsc --noEmit, andgit diff --checkpass with the combined locked versions. The installed test app has not been changed by this consolidation. Original Dependabot PRs are left open pending merge of this PR.Security dependency fixes
npm ci,npm audit --jsonreports zero vulnerabilities. Regression tests, production build, TypeScript, and diff checks pass with the final dependency set.