Skip to content

fix(setup): gate VC++ on Steam detection and consolidate dependency updates - #586

Merged
aaf2tbz merged 16 commits into
mainfrom
fix/quick-fixes
Sep 8, 2026
Merged

fix(setup): gate VC++ on Steam detection and consolidate dependency updates#586
aaf2tbz merged 16 commits into
mainfrom
fix/quick-fixes

Conversation

@aaf2tbz

@aaf2tbz aaf2tbz commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Prevent setup from advancing to VC++ until Windows Steam is detected as installed and no installation is in progress.

Changes

  • Disable Next until Steam installation is confirmed.
  • Recheck Steam status on click and block duplicate clicks during confirmation.
  • Clear stale installed state on failed detection or installation retries.
  • Add five regression tests covering timing and failure cases.

Validation

  • node --test app/tests/setup-steam-gate.cjs: five tests pass.
  • cd app && npm run build: passes.
  • git diff --check: passes.

Scope / risk

Setup renderer guard plus dependency updates; no C backend, application-version, Wine/graphics-payload, or migration changes. Electron is updated to major version 44 and needs desktop runtime testing. Fresh-install UI testing has not been performed. Revert this commit to restore the previous navigation behavior.

PR Readiness (MANDATORY)

  • Compatibility verified with at least one real game (game + launch method noted below)
  • No hardcoded paths, secrets, or absolute /Users/... paths introduced
  • Config/rules TOML validated if configs/mtsp-rules.toml or DLL maps changed — not changed
  • Version metadata (CMakeLists.txt, app/src-c/Makefile, package.json, package-lock.json) in sync if version bumped — no version bump
  • Bottle/runtime migration and launch behavior preserved (rollback plan noted if changed) — no changes to these paths
  • Docs / compatibility matrix updated for user-facing changes
  • Regression test added for each bug fix

Checklist exception rationale

Uses the existing checklist-exception policy for the setup-navigation guard and consolidated dependency updates. Electron 44 has build/type validation but has not been tested interactively. No real-game compatibility or fresh-install manual validation is claimed; automated tests exercise blocked navigation, pending/duplicate clicks, positive detection, stale status, and request failure. No compatibility-matrix entry was added because graphics/game launch behavior is unchanged. The user-visible effect is documented in this PR summary. CI workflow requirements have not been modified.

Consolidated Dependabot updates

Merged the five currently open Dependabot branches into this PR (not directly into main):

Resolved adjacent Electron/plugin-vue conflicts in both package manifests by retaining both updates. npm ci, the five setup regression tests, npm run build, npx tsc --noEmit, and git diff --check pass with the combined locked versions. The installed test app has not been changed by this consolidation. Original Dependabot PRs are left open pending merge of this PR.

Security dependency fixes

dependabot Bot and others added 6 commits August 20, 2026 21:07
Bumps [@vitejs/plugin-vue](https://github.com/vitejs/vite-plugin-vue/tree/HEAD/packages/plugin-vue) from 6.0.7 to 6.0.8.
- [Release notes](https://github.com/vitejs/vite-plugin-vue/releases)
- [Changelog](https://github.com/vitejs/vite-plugin-vue/blob/main/packages/plugin-vue/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite-plugin-vue/commits/plugin-vue@6.0.8/packages/plugin-vue)

---
updated-dependencies:
- dependency-name: "@vitejs/plugin-vue"
  dependency-version: 6.0.8
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.5.8 to 2.5.10.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.10/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.5.10
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@iconify-json/lucide](https://github.com/iconify/icon-sets) from 1.2.118 to 1.2.126.
- [Commits](https://github.com/iconify/icon-sets/commits)

---
updated-dependencies:
- dependency-name: "@iconify-json/lucide"
  dependency-version: 1.2.126
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [electron](https://github.com/electron/electron) from 43.4.0 to 44.0.0.
- [Release notes](https://github.com/electron/electron/releases)
- [Commits](electron/electron@v43.4.0...v44.0.0)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 44.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [marked](https://github.com/markedjs/marked) from 18.0.9 to 18.0.11.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Commits](markedjs/marked@v18.0.9...v18.0.11)

---
updated-dependencies:
- dependency-name: marked
  dependency-version: 18.0.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@aaf2tbz aaf2tbz added the checklist-exception Bypass mandatory PR readiness checklist when an item is intentionally not applicable label Sep 8, 2026
@aaf2tbz aaf2tbz changed the title fix(setup): wait for Steam installation before VC++ fix(setup): gate VC++ on Steam detection and consolidate dependency updates Sep 8, 2026
@aaf2tbz
aaf2tbz merged commit 4aa4844 into main Sep 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checklist-exception Bypass mandatory PR readiness checklist when an item is intentionally not applicable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant