Repository navigation
[pulse][taint] do not taint the receiver of unknown String methods - #2288
Merged
dulmarod merged 1 commit intoOct 29, 2026
Merged
Conversation
By default, an unknown instance method that returns a non-object value propagates the taint of its arguments to its receiver. For `java.lang.String`, this taints a constant compared with a tainted string, e.g. after `cookieName.equals(cookie.getName())`, although a string is immutable. Do not propagate the taint of these methods: their primitive results are not tracked as tainted either. On OWASP BenchmarkJava, this removes 332 false trust boundary violations, without changing any other result.
jeremydubreil
force-pushed
the
java-taint-immutable-string-receiver
branch
from
October 29, 2026 00:48
9c821d9 to
27c8973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, an unknown instance method that returns a non-object value propagates the taint of its arguments to its receiver. For
java.lang.String, this taints a constant compared with a tainted string, e.g. aftercookieName.equals(cookie.getName()), although a string is immutable. Do not propagate the taint of these methods: their primitive results are not tracked as tainted either.On OWASP BenchmarkJava, this removes 332 false trust boundary violations, without changing any other result.