Repository navigation
[windows][build] patch base_bigstring with a memmem fallback for Windows - #2281
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opam-repository marks
base_bigstring.v0.17.0as unavailable on win32 (ocaml/opam-repository#29040), because its stubs callmemmem(), which the Windows C runtimes do not provide. Ascoredepends on it, this blocks the installation of infer's dependencies on Windows.This adds
base_bigstring.v0.17.0to infer's local opam repository, as was done for pyml in #2262: opam-repository's definition without the win32 restriction, plus a patch with amemmem()fallback, compiled only with mingw-w64 or MSVC. On Linux and macOS, the fallback is not compiled, so the library is unchanged.The same patch could also go to opam-repository, or to
janestreet/base_bigstring, whose maintainers said they accept Windows patches (janestreet/base_bigstring#6). Once a released or opam-repository version builds on Windows, this package can be removed.