Repository navigation
Fix FreeBSD build with FOLLY_USE_JEMALLOC=OFF and header in MallctlHelperTest - #2732
siddiqueirshad wants to merge 1 commit into
Conversation
…n MallctlHelperTest On FreeBSD: 1. When FOLLY_USE_JEMALLOC is OFF, folly/portability/Malloc.h skipped including <malloc_np.h>, resulting in missing declarations for mallocx, rallocx, mallctl, and related allocator symbols in downstream translation units. Include <malloc_np.h> on FreeBSD in the fallback branch so standard non-standard allocator APIs remain available. 2. In MallctlHelperTest.cpp, FreeBSD uses <malloc_np.h> instead of <jemalloc/jemalloc.h>. Conditionally include <malloc_np.h> on FreeBSD and safely guard JEMALLOC_VERSION_MAJOR. Fixes meta#2720 Fixes meta#2721 Fixes meta#1893 Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
|
Hi @siddiqueirshad! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary of changes
On FreeBSD:
allocx, \mallctl, and related allocator APIs in downstream translation units. This change includes <malloc_np.h>\ on FreeBSD in the fallback branch of \olly/portability/Malloc.h\ so allocator symbols remain available.
Closes #2720
Closes #2721
Closes #1893