Repository navigation
[Nexthop][m4340nhp] Fix ACL tests and trap ACLs on split-ACL DNX ASICs - #1887
Open
marif-nexthop wants to merge 1 commit into
Open
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
With ACL table groups, Qumran4D and Jericho4 split the default ingress ACL into an IPv4 table and an IPv6 table. This PR fits the trap ACL helpers and
AclEmptyCodeIcmpto that split.addTrapPacketAcl()puts IPv6 prefix and L4 port trap entries in the IPv6 table on these ASICs. The IPv4 table does not carry the IPv6 qualifiers.AclEmptyCodeIcmpgives its ICMPv6 entry the IPv6 ether type on every ASIC that takes an ether type, and looks the entry up in the IPv6 table on these ASICs.isAclEntrySamethrowsFbossErrorwhen the table or the entry is missing, instead of dereferencing a null handle.Test Plan
Tested on a
m4340nhpdevice.AgentHwAclQualifierTest.AclEmptyCodeIcmpcrashed inisAclEntrySamebefore this change and passes on cold and warm boot with it.