Repository navigation
[Nexthop][m4340nhp] Use the 1024-port DSF block in agent HW test configs - #1885
Open
marif-nexthop wants to merge 1 commit into
Open
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Agent HW tests on m4340nhp aborted at init with
Interface intfID :522 is out of range for corresponding VOQ switch sys port range, because the test config fell back to a 44-port system port block.getRdswSysPortBlockSize()returns the 1024-port block for m4340nhp, as it does for blackwolf800banw.populateSwitchInfo()takes the m4340nhp DSF node's system port ranges, offsets and inband port fromswitchInfo, as it does for janga800bic. The computed defaults gave a local system port offset of 0 instead of 17.Test Plan
Tested on a
m4340nhpdevice.AgentEmptyVoqTest.CheckInit,AgentVoqSwitchTest.addRemoveNeighborandAgentVoqSwitchTest.sendPacketCpuAndFrontPanelpass on cold and warm boot.