Repository navigation
[Nexthop][m4061nhp] Report switch-card rails from the DCDCs instead of the DPMs - #1870
Open
frank-nexthop wants to merge 1 commit into
Open
frank-nexthop wants to merge 1 commit into
frank-nexthop wants to merge 1 commit into
Conversation
The two switch-card ADM1266 DPMs sense the ASIC rails near the source, so under load they read 40-75 mV above the regulator output. For the 18 DPM channels whose rail is also made by a digital DCDC (DCDC0-10), drop the DPM sensor and add a DCDCn_<RAIL>_VOUT sensor that reads the regulator directly. That also adds the PT1/PT3/PT4/PT6 loops, which no DPM channel watches. DCDC0 iout1 replaces the DPM VDDC IMON channel. Thresholds mirror the limits the hwmon driver reports for each DCDC: DCDC1-10 only expose VOUT fault limits (lcrit/crit), so those rails get a critical band only; DCDC0 also exposes min/max, used as the alarm band. The 3V3 limits get the same 6/5 divider scaling as the reading. The adm1266 driver stays loaded, so the raw DPM values remain available outside sensor_service. Signed-off-by: frank-nexthop <frank@nexthop.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
On m4061nhp, the switch-card ADM1266 DPMs sense the ASIC rails near the source, so under load they read 40–75 mV above the regulator output.
For the 18 DPM channels whose rail is also made by a DCDC (DCDC0–10), replace the DPM sensor with a
DCDCn_<RAIL>_VOUTsensor that reads the regulator's own output. Also add the four PT loops that no DPM channel watches, and DCDC0's VDDC current. Thresholds are the limits each DCDC's hwmon driver reports.The DCDC devices are already in
platform_manager.json, so this doesn't depend on the other open m4061nhp PRs.Test Plan
On m4061nhp hardware,
sensor_service_hw_testpasses 8/8, includingCheckAllSensors, and every new sensor stays within its limits with all ports at line rate.