Repository navigation
[Nexthop][feature] "asic_config_v3" - Support all four config_gen_type values - #1789
Open
marif-nexthop wants to merge 1 commit into
Open
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
marif-nexthop
force-pushed
the
marif.fboss-asic-config-v3-config-gen-type
branch
3 times, most recently
from
October 15, 2026 07:42
d0095d8 to
256adc3
Compare
marif-nexthop
marked this pull request as ready for review
October 15, 2026 07:43
marif-nexthop
force-pushed
the
marif.fboss-asic-config-v3-config-gen-type
branch
from
October 20, 2026 03:26
256adc3 to
acbd2b4
Compare
marif-nexthop
force-pushed
the
marif.fboss-asic-config-v3-config-gen-type
branch
from
October 22, 2026 18:37
acbd2b4 to
744897f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Implements
asic_config_v3design.In this PR, support all four
AsicConfigGenTypevalues.BENCHMARKandLINK_TESTin addition toDEFAULTandHW_TEST.BENCHMARKreferences fromfboss/oss/hw_bench_configsandLINK_TESTreferences fromfboss/oss/link_test_configs.Also made change in the generator so that
config_gen_typeis fully data-driven.HW_TESTandLINK_TEST.This confirms to the design that the ASIC file describes the silicon and platform file decides what a test profile needs.
This PR is stacked on #1736
Test Plan
Regenerated every platform with the
asic_config_v3generator. The only outputs that changed are the twohw_test.ymlfiles, wheresai_uncached_port_statsmoves after the keys written by the ASIC-level conditional settings.Ran the content validator:
Validated the ASIC and platform configs against the schemas: