Repository navigation
chore(deps): upgrade mdast-util-directive to 3.1.1 and mdast-util-to-markdown to 2.2.0 (AI-assisted) - #12809
Merged
Conversation
…markdown to 2.2.0 (AI-assisted) mdast-util-directive 3.1.1 relies on the `unicode` and `afterNode` unsafe pattern options added in mdast-util-to-markdown 2.2.0, but still declares `mdast-util-to-markdown@^2.0.0`. With the 2.1.2 version our lockfile resolved, colons followed by punctuation were escaped (`https\://`). Supersedes #12804. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update catalog version pnpm-workspace.yaml |
The workspace catalog entry for mdast-util-directive changes from 3.1.0 to 3.1.1. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Other
Possibly related PRs
- meta/docusaurus#12804: Updates
mdast-util-directivefrom3.1.0to3.1.1; PR#12809supersedes it.
Suggested reviewers: josh-cena
Merge Risk: 
1263a
-
The dependency update is ready to merge with no identified blocking risk.
Architecture risk: 
1263a
-
The change affects 1 system.
Changed systems:
pnpm-workspace.yamlArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in pnpm-workspace.yaml: The
mdast-util-directivecatalog entry changes from version3.1.0to3.1.1.
-
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names the two dependency changes the PR makes: upgrading mdast-util-directive to 3.1.1 and mdast-util-to-markdown to 2.2.0. The raw summary covers only the mdast-util-directive catalog bump … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the two dependency changes the PR makes: upgrading mdast-util-directive to 3.1.1 and mdast-util-to-markdown to 2.2.0. The raw summary covers only the mdast-util-directive catalog bump in pnpm-workspace.yaml. The lockfile change that locks mdast-util-to-markdown to 2.2.0 is excluded from review, so the summary cannot confirm it. The objectives state that this lock change is the intended fix, so the title is related to the stated goal. The title is specific and describes a real change. It is not vague, and it is not unrelated to the changeset.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Supersedes the Dependabot PR #12804, which upgrades
mdast-util-directiveto 3.1.1 and fails 4 admonition snapshot tests.mdast-util-directive@3.1.1(colon escaping fix) relies on theunicodeandafterNodeunsafe pattern options added inmdast-util-to-markdown@2.2.0, but still declaresmdast-util-to-markdown@^2.0.0. Our lockfile resolved 2.1.2, which ignores these options: its regex is built without theuflag, so\p{P}no longer matches punctuation, and colons followed by punctuation get escaped (https://→https\://, which our snapshot path normalizer displays ashttps/://).This PR also upgrades the transitive
mdast-util-to-markdowndependency to 2.2.0 in the lockfile. 2.2.1 is not allowed yet by our 7-dayminimumReleaseAge.No impact on Docusaurus sites: Docusaurus never serializes Markdown at runtime, only our tests do with
remark-stringify. Fresh installs already resolvemdast-util-to-markdown@2.2.x.Test Plan
CI. Locally,
pnpm testpasses with no snapshot changes.Test links
Deploy preview: https://deploy-preview-12809--docusaurus-2.netlify.app/
Related issues/PRs
mdast-util-directivedependency range: Fix range ofmdast-util-to-markdownsyntax-tree/mdast-util-directive#22🤖 Generated with Claude Code
Summary by CodeRabbit