Skip to content

fix(theme-classic): render mobile HTML navbar items as list items #12806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khushalrajput45 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(theme-classic): render mobile HTML navbar items as list items #12806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/src/theme/NavbarItem/HtmlNavbarItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default function HtmlNavbarItem({
mobile = false,
isDropdownItem = false,
}: Props): ReactNode {
const Comp = isDropdownItem ? 'li' : 'div';
const Comp = mobile || isDropdownItem ? 'li' : 'div';
return (
<Comp
className={clsx(
Expand Down
29 changes: 29 additions & 0 deletions packages/docusaurus-theme-classic/src/theme/NavbarItem/__tests__/HtmlNavbarItem.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// @vitest-environment jsdom

import {describe, expect, it} from 'vitest';
import {render} from '@testing-library/react';
import '@testing-library/jest-dom/vitest';

import HtmlNavbarItem from '../HtmlNavbarItem';

describe('HtmlNavbarItem', () => {
it('renders a li element on mobile', () => {
const {container} = render(<HtmlNavbarItem value="Example" mobile />);

expect(container.firstElementChild?.tagName).toBe('LI');
});

it('renders a div element on desktop', () => {
const {container} = render(<HtmlNavbarItem value="Example" />);

expect(container.firstElementChild?.tagName).toBe('DIV');
});

it('renders a li element for dropdown items', () => {
const {container} = render(
<HtmlNavbarItem value="Example" isDropdownItem />,
);

expect(container.firstElementChild?.tagName).toBe('LI');
});
});