Repository navigation
fix(ci): don't proxy our unscoped packages in the E2E Verdaccio registry (AI-assisted) - #12795
Merged
Merged
Conversation
…try (AI-assisted) The unpinned verdaccio/verdaccio:latest image moved from 6.10.7 to 7.0.2. Verdaccio 7 rejects publishing a package that exists on a proxied uplink with a 409 "this package is already present", so every E2E job failed to publish stylelint-copyright (and would fail on create-docusaurus next). Isolate both packages from npmjs like the @docusaurus/* packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
the
pr: maintenance
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Package access rules admin/verdaccio.yaml |
Adds rules for create-docusaurus and stylelint-copyright. Both allow all users access and publishing, with no proxy specified. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: josh-cena
Merge Risk: 
efe17
-
The configuration change is consistent with the stated E2E registry goal and presents no identified merge-blocking risk.
Security architecture risk: efe17
-
The change isolates two test packages from npmjs without expanding registry permissions or network exposure. No material security risk introduced or worsened by this PR was identified.
Retained concerns
No architecture-level concerns identified.Security review details
-
Security Blast Radius
- inferred — The changed resolution behavior is bounded to two names in the test registry. A party able to publish attacker-controlled packages there could affect downstream test execution, but the registry’s unrestricted publication authority and package-execution path already existed.
Trust Boundaries and Controls
- observed — The script uses localhost as its registry destination, but Docker publishes port 4873 without an explicit loopback binding. That exposure setting is unchanged; localhost consumers alone do not establish network isolation.
-
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main change: preventing the E2E Verdaccio registry from proxying the project's unscoped packages. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
All the E2E jobs that publish to a local Verdaccio registry fail since Verdaccio 7 became the
verdaccio/verdaccio:latestDocker image (2026-10-26):mainrun (40021423874) pulledsha256:d394c36d…= Verdaccio 6.10.7.sha256:5623458a…= Verdaccio 7.0.2.Verdaccio 7 publishes through
@verdaccio/store: withpublish.allow_offline: false, it rejects publishing any version of a package that exists on a proxied uplink. Verdaccio 6 raised the same conflict but its publish endpoint ignored it.Our unscoped packages
stylelint-copyrightandcreate-docusaurusexist on npm and fall under the'**'rule that proxies npmjs. This PR isolates them from the uplink, like the@docusaurus/*packages, instead of pinning Verdaccio 6.Test Plan
CI: the E2E jobs should publish all packages again and pass.
Test links
Deploy preview: https://deploy-preview-12795--docusaurus-2.netlify.app/
Related issues/PRs
Unblocks #12699 and other PRs whose E2E jobs fail on this 409.
(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit
create-docusaurusandstylelint-copyright. Both packages are accessible to all users, and all users can publish them.