Repository navigation
ci: the interaction job loads the heavy-suite caps from the merge commit, not the pull request head - #9005
Merged
Conversation
…mit, not the pull request head pr-interaction checks out the pull request's exact head and then ran the local heavy-caps action from it, so a pull request branched before the action existed failed with "Can't find 'action.yml'" and turned the required test check red. The job now sparse-checks-out the action from the merge commit into a side path and runs it there before the head checkout. test-build and fixture-contrast check out the merge commit and were not affected. A contract test now holds every local action except setup to a checkout that is not the pull request head.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Recommending approval: loading the heavy-suite caps from the merge commit means a branch cut before #8893 gets its per-author caps and interaction proofs, as AST-030 FR16 expects, instead of failing test on a missing action. The new all-workflow contract fails on the previous pr-interaction layout and passes with this change, so nothing else is needed from you.
[Automated review]
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User impact
testcheck: the interaction job runs the heavy-suite caps step from the pull request's own head, which does not have it ("Can't find 'action.yml'").Changes
ci.ymlpr-interaction: a sparse checkout of.github/actions/heavy-capsfrom the merge commit into.heavy-caps, the caps step and its marker from there, then the existing head checkout, which replaces that directory.test-buildandfixture-contrast: unchanged. They check out the merge commit, which always has the step.heavy-caps-action.test.mjsadds a contract over every workflow: a local action other thansetup(the pull request's own toolchain) must not load from a checkout of the pull request head. Onmaintoday this test fails forpr-interaction.ci-test-routing.test.mjsreads the workspace checkout, not the side one.Evidence
.github/scriptsNode suite: 1,523 pass.mainworkflow and passes with this change.Scope
LOC
+66/−9. The workflow change is about +12; the rest is the contract test.