Repository navigation
Conversation
Limit generated domains for unary ops with restricted real\ninputs.\n\nConstrain acos and asin to [-1, 1], acosh to [1, inf),\natanh to (-1, 1), sqrt to [0, inf), rsqrt and log ops\nto (0, inf), and log1p to (-1, inf). This keeps FACTO\nfrom generating invalid real-valued cases that show up\nas AoT and export noise.
meta-cla
Bot
added
the
CLA Signed
Constrain logit inputs to [0, 1] when eps is None and\nrequire non-zero divisors for div.Tensor_mode with\nrounding_mode, floor_divide.default, and\nremainder.Tensor.\n\nThis reduces invalid generated cases that show up as\nbackend noise in Arm FACTO runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit generated domains for invalid unary and divisor inputs.
Constrain acos and asin to [-1, 1], acosh to [1, inf), atanh to (-1, 1), sqrt to [0, inf), rsqrt and log ops to (0, inf), and log1p to (-1, inf).
Also constrain logit inputs to [0, 1] when eps is None, and require non-zero divisors for div.Tensor_mode, floor_divide.default, and remainder.Tensor.
This keeps FACTO from generating invalid cases that show up as AoT, export, and runtime noise.