Repository navigation
Pass all length/ix arguments to AttributeEngine - #62
Open
manuelcandales wants to merge 1 commit into
Open
manuelcandales wants to merge 1 commit into
manuelcandales wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
manuelcandales
force-pushed
the
manuel/tensorlist-size
branch
from
February 11, 2026 02:14
9b5d036 to
80fd0c3
Compare
|
@manuelcandales has imported this pull request. If you are a Meta employee, you can view this in D92911167. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the argument structure generation logic in
facto/inputgen/argument/engine.pyto ensure that dependency arguments (args) are consistently threaded through recursive calls. Additionally, a new test is added to verify the correct handling of tensor list constraints.Refactoring for argument threading:
gen_structure_with_depth_and_lengthandgen_structure_with_depthto accept and propagate anargstuple, ensuring dependencies are correctly passed through recursive calls. [1] [2] [3] [4] [5] [6]Testing improvements:
test_tensor_listtotest/inputgen/test_meta_arg_engine.pyto verify that tensor list constraints are handled correctly and produce the expected structure.