Repository navigation
fix(auth): refresh under the lock, finish a started refresh, retry a replaced token [ENG-5309] - #43
Merged
Merged
Conversation
…replaced token [ENG-5309] - The OAuth refresh runs under the credentials lock and re-reads the profile there, so parallel commands refresh once and the rest adopt the new token. - From the refresh request to the save, forced exits (a second Ctrl-C, the end of a terminate signal's grace period) wait, so a rotated refresh token is never lost. - After a 401 with an OAuth token (stored or host-provided), the request is retried once with the token now stored for the same login: the API ends the previous access token as soon as another process refreshes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PowerShell can take several seconds to start; a 5 s limit made a cold or busy Windows machine fall back to the key file, or fail to open a stored login. DPAPI never prompts, so it now waits up to 30 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A token refresh in one process no longer breaks the others. The API ends the previous access token as soon as it issues a new one, so before this change a refresh in one command (a terminal, another agent, a host app) made every other holder of the old token fail with 401: a running
wait, or a credential a host app handed over.Fixed
DSH_MESHY_CREDENTIAL), the request is retried once with the token now stored for the same login. Another account's token is never used.🤖 Generated with Claude Code