fix(combobox): prevent collapse to 1px in flex align-items:center containers#2237
Open
yordan-st wants to merge 1 commit into
Open
fix(combobox): prevent collapse to 1px in flex align-items:center containers#2237yordan-st wants to merge 1 commit into
yordan-st wants to merge 1 commit into
Conversation
afca5ab to
84a04df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
align-items: center.form-group.no-columns(column flex, no explicit width) between the user's container and.widget-combobox.flex-grow: 1distributes height in a column container, not width. Children suppressmin-widthto ~0 viamin-width: 0on.widget-combobox-selected-items(intentional, needed for multiselect tag wrapping)min-width: 15chon.widget-combobox— explicit value does not ask children, breaking the collapse chain.chscales with font-size rather than using pxChanges
src/ui/Combobox.scss—min-width: 15chon.widget-comboboxroot rulesrc/__tests__/ComboboxStyles.spec.ts— unit test updated to assert15che2e/Combobox.spec.js— E2E regression tests added (pending Studio Pro test page at/p/combobox-flex-layout)openspec/changes/fix-combobox-flex-collapse/— design artifacts with corrected root cause analysisTest plan
display: flex; flex-flow: row; align-items: center(e.g. add a classrow-centerand define it in a custom stylesheet).Override
To restore previous behavior:
.widget-combobox { min-width: 0; }in app CSS.