Skip to content

feat(runner-policy): register the ci-workflows v0.68.0 pr-review-cli contract - #912

Closed
kyle-sexton wants to merge 1 commit into
mainfrom
feat/runner-policy-pr-review-cli-settled-threads
Closed

kyle-sexton wants to merge 1 commit into
mainfrom
feat/runner-policy-pr-review-cli-settled-threads

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: unblocks the claude-code-plugins repin of the review lanes to ci-workflows v0.68.0 (melodic-software/ci-workflows#921).

Summary

Registers the reviewed pr-review-cli.yml@0691df79a6c0de7f1e49df618ac7b321605563f9 (v0.68.0) contract. Surface-diff auto-approval would decline the claude-code-plugins repin: v0.68.0 adds a $/.github/actions/collect-settled-threads step that has no git object at the reviewed v0.66.1 SHA (runner-policy.mjs, commitRelativeObjects).

Fix

  • policy.json: the new entry copies the v0.66.1 (20a822d) entry forward unchanged. From 20a822d to 0691df7, pr-review-cli.yml changes only these lines: the new settled-threads step in each of the three model legs, those legs' timeout-minutes (+2), and one usage comment. The new action reads review threads through actions/github-script with the job's existing github.token. No input, secret, permission or routing change.
  • README.md: a v0.68.0 paragraph naming ci-workflows#921.
  • runner-policy.test.mjs: pins the new entry as equal to its v0.66.1 entry.

Ordering agreed with the session holding standards#911: this additive entry lands first, and #911 merges main when it refreshes.

Verification

  • node --test components/runner-policy/runner-policy.test.mjs: 374 pass, 0 fail.
  • Surface diff: git diff -U0 20a822d 0691df7 -- .github/workflows/pr-review-cli.yml shows no permissions, secrets, inputs, runs-on or workflow_call line.

Related

🤖 Generated with Claude Code

…contract

Copies the v0.66.1 entry forward unchanged: v0.68.0 adds a $/
settled-threads step to each model leg (ci-workflows#921) with no input,
secret, permission or routing change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T08:10:17.387333Z 1342be0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kyle-sexton kyle-sexton added the do-not-merge Hard merge gate: do not merge while applied. label Oct 30, 2026
@kyle-sexton

Copy link
Copy Markdown
Member Author

Closing: no longer needed. standards#911 keys runner-policy by bare path, and melodic-software/claude-code-plugins#11097 floats the review lanes' pr-review-cli.yml ref on @main, which already contains melodic-software/ci-workflows#921 (v0.68.0, 0691df7). The README asks for no new approvedShas entries, so this path@SHA entry and the SHA repin are dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Hard merge gate: do not merge while applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant