Skip to content

feat(runner-policy): register the ci-workflows v0.66.1 pr-review-cli contract #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 28, 2026
Merged

feat(runner-policy): register the ci-workflows v0.66.1 pr-review-cli contract #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions components/runner-policy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,6 +1483,15 @@ renames the review lanes' fallback secret slot from
`fallback-claude-code-oauth-token` to that name (ci-workflows#897), so a
caller maps the central fallback subscription under its own name. The lane
retries once on it after a usage limit only. No permission or routing change.
At the v0.66.1 tag `20a822d73b6e2d7e21d48e609a01b427e0e161e7`, the
pr-review-cli contract copies its v0.65.14 entry forward unchanged: the
release has the status job take a cost decision's decided head from this
lane's earlier check-run notices (ci-workflows#904), so that job's
permissions add `actions: read` and `checks: read` and its hold step takes a
`STATUS_JOB` env built from the `lane` input. The contract records no job
permissions, and a hosted-only contract checks no caller permissions, so the
callers' read grants need no entry. No input, secret, write permission or
routing change.
The Zizmor contract at `de50a08b6093d231519ee7a4c9371db76c0a7e1e`
uses its reviewed `runner` input and checksum-verified native Linux binary, so
enrolled consumers may route that advisory lane onto the managed fleet
Expand Down
22 changes: 22 additions & 0 deletions components/runner-policy/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,6 +1409,28 @@
"FALLBACK_CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.FALLBACK_CLAUDE_CODE_OAUTH_TOKEN }}"
}
},
"melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@20a822d73b6e2d7e21d48e609a01b427e0e161e7": {
"routing": "hosted-only",
"fixedRunsOn": ["ubuntu-24.04"],
"allowedInputs": [
"lane",
"publish",
"role",
"model-args",
"allowed-bot-sender-ids",
"allowed-author-ids",
"docs-only-paths",
"incremental-review",
"cli-version",
"hold-label",
"hold-paths"
],
"allowedSecrets": {
"CLAUDE_API_KEY": "${{ secrets.REVIEWS_CLAUDE_API_KEY }}",
"CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.REVIEWS_CLAUDE_CODE_OAUTH_TOKEN }}",
"FALLBACK_CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.FALLBACK_CLAUDE_CODE_OAUTH_TOKEN }}"
}
},
"melodic-software/ci-workflows/.github/workflows/intake-label-needs-triage.yml@ab83b01273026ab5c23c6f3b40e946d97a863fa2": {
"routing": "runner-input",
"runnerInput": "runner",
Expand Down
15 changes: 15 additions & 0 deletions components/runner-policy/runner-policy.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10554,3 +10554,18 @@ test("the pr-review and pr-review-security contracts at the v0.65.16 tag add onl
}
assert.equal(Object.keys(contracts).filter((k) => k.endsWith(`@${sha}`)).length, 2);
});

// v0.66.1 adds actions: read and checks: read to the pr-review-cli status job
// (ci-workflows#904). The hosted-only contract records no job permissions, so
// the entry copies its v0.65.14 entry forward unchanged.
test("the pr-review-cli contract at the v0.66.1 tag copies its v0.65.14 entry forward unchanged", () => {
const contracts = BASE_POLICY.approvedReusableWorkflowContracts;
const key = (sha) => `melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@${sha}`;
const sha = "20a822d73b6e2d7e21d48e609a01b427e0e161e7";
const prior = contracts[key(REPINE_LANE_SHA_V0_65_14)];
assert.ok(prior);
assert.deepEqual(contracts[key(sha)], prior);
assert.equal(contracts[key(sha)].routing, "hosted-only");
assert.equal(contracts[key(sha)].allowedCallerPermissions, undefined);
assert.equal(Object.keys(contracts).filter((k) => k.endsWith(`@${sha}`)).length, 1);
});
Loading