Repository navigation
fix(claude-lanes): biome-format policy.json after the re-pin lockstep - #901
Conversation
The lockstep writes policy.json with JSON.stringify, which expands the short arrays Biome keeps inline, so every re-pin pull request that moved a contract failed check-typescript. Format the file with the Biome the root lockfile pins, the version and config check-typescript runs. Refs: melodic-software/claude-code-plugins#9635 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. The PR adds one step, What I checked in the repository:
I did not run the step myself:
No manifest items, no closing issue (the PR uses |
|
claude-security-review reviewed No security issues found in PR #901 at 70452a0. The PR adds one step to
Manifest items: none hit. No plugin manifests changed. critical-findings: 0 |
Refs: melodic-software/claude-code-plugins#9635
Summary
Every re-pin pull request whose lockstep copies a runner-policy contract forward fails
check-typescript, becauserepin-policy-lockstep.mjswritespolicy.jsonwithJSON.stringify(policy, null, 2). That spreads short arrays such asallowedInputsover oneline per item, and Biome's format check (
File content differs from formatting output) rejectsthe file. #895 failed this way at 09f6f35.
Fix
maintenance-repin-ci-workflows.ymlgains a step after the lockstep step, gated on the samesteps.repin.outputs.changed == 'true'. It runsnpm ci --ignore-scriptsat the root andnode_modules/.bin/biome format --write --config-path=components/biome/biome.jsononcomponents/runner-policy/policy.json. The root lockfile pins@biomejs/biome2.5.15, theversion
check-typescript's biome action derives from the rootpackage.json, and the configis the one
check-typescriptpasses. No new action and no new permission.Verification
policy.json(09f6f35): the output isbyte-identical to the hand-formatted fix cc1d460, on which
check-typescriptandci-statuspass.
actionlintandzizmor(offline) report nothing for the workflow.repin-callers.test.shcovers the script.Related
components/runner-policy/policy.json.🤖 Generated with Claude Code