Skip to content

fix(runner-policy): approve pr-review-cli.yml v0.66.1 contract with status job reads #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 29, 2026
Merged

fix(runner-policy): approve pr-review-cli.yml v0.66.1 contract with status job reads #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/runner-policy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,13 @@ At the v0.65.14 tag `3180217076b19bbdfccc43026c7f91c604da673d`, the pr-review-cl
contract copies its v0.65.13 entry forward unchanged: the release reports a
failed "Isolate the runner" install as install-failed (ci-workflows#893), with
no input, secret, permission or routing change.
At the same tag, the claude-lanes re-pin moves `pr-review`,
At the v0.66.1 tag `20a822d73b6e2d7e21d48e609a01b427e0e161e7`, the pr-review-cli
contract copies its v0.65.14 entry forward unchanged. The one surface change is
reviewed here: since ci-workflows#904 the status job's `permissions:` block adds
`actions: read` and `checks: read` to read its earlier runs' cost hold notices.
Both are read-only scopes its callers already grant, and a hosted-only contract
records no caller permissions. Inputs, secrets and routing are unchanged.
At the v0.65.14 tag, the claude-lanes re-pin moves `pr-review`,
`pr-review-security` and `maintenance-sync-standards` off v0.55.0.
`pr-review` and `pr-review-security` copy their v0.62.0 entries forward
verbatim: since v0.62.0 each only gives the isolation install step an id and
Expand Down
22 changes: 22 additions & 0 deletions components/runner-policy/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,6 +1409,28 @@
"FALLBACK_CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.FALLBACK_CLAUDE_CODE_OAUTH_TOKEN }}"
}
},
"melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@20a822d73b6e2d7e21d48e609a01b427e0e161e7": {
"routing": "hosted-only",
"fixedRunsOn": ["ubuntu-24.04"],
"allowedInputs": [
"lane",
"publish",
"role",
"model-args",
"allowed-bot-sender-ids",
"allowed-author-ids",
"docs-only-paths",
"incremental-review",
"cli-version",
"hold-label",
"hold-paths"
],
"allowedSecrets": {
"CLAUDE_API_KEY": "${{ secrets.REVIEWS_CLAUDE_API_KEY }}",
"CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.REVIEWS_CLAUDE_CODE_OAUTH_TOKEN }}",
"FALLBACK_CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.FALLBACK_CLAUDE_CODE_OAUTH_TOKEN }}"
}
},
"melodic-software/ci-workflows/.github/workflows/intake-label-needs-triage.yml@ab83b01273026ab5c23c6f3b40e946d97a863fa2": {
"routing": "runner-input",
"runnerInput": "runner",
Expand Down
12 changes: 12 additions & 0 deletions components/runner-policy/runner-policy.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10343,6 +10343,18 @@ test("the pr-review-cli contract at the v0.65.14 tag copies its v0.65.13 entry u
assert.deepEqual(contracts[key(sha)], contracts[key(previous)]);
});

// v0.66.1's status job adds actions: read and checks: read (ci-workflows#904),
// read-only scopes a hosted-only contract does not record; inputs, secrets and
// routing are unchanged, so the entry copies v0.65.14 forward.
test("the pr-review-cli contract at the v0.66.1 tag copies its v0.65.14 entry unchanged", () => {
const contracts = BASE_POLICY.approvedReusableWorkflowContracts;
const key = (sha) => `melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@${sha}`;
const sha = "20a822d73b6e2d7e21d48e609a01b427e0e161e7";
const previous = "3180217076b19bbdfccc43026c7f91c604da673d";
assert.ok(contracts[key(previous)]);
assert.deepEqual(contracts[key(sha)], contracts[key(previous)]);
});

// At v0.65.14 the claude-lanes re-pin leaves v0.55.0. Both review workflows
// differ from v0.62.0 only in the isolation install step's id and its
// install-failed class; maintenance-sync-standards is byte-identical to
Expand Down
Loading