Skip to content

feat(runner-policy): register the ci-workflows v0.65.7 pr-review-cli contract #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 24, 2026
Merged

feat(runner-policy): register the ci-workflows v0.65.7 pr-review-cli contract #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions components/runner-policy/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,27 @@
"CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.REVIEWS_CLAUDE_CODE_OAUTH_TOKEN }}"
}
},
"melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@4c531cea137f5cbb38d4c132dbfa6e38f76fba7d": {
"routing": "hosted-only",
"fixedRunsOn": ["ubuntu-24.04"],
"allowedInputs": [
"lane",
"publish",
"role",
"model-args",
"allowed-bot-sender-ids",
"allowed-author-ids",
"docs-only-paths",
"incremental-review",
"cli-version",
"hold-label",
"hold-paths"
],
"allowedSecrets": {
"CLAUDE_API_KEY": "${{ secrets.REVIEWS_CLAUDE_API_KEY }}",
"CLAUDE_CODE_OAUTH_TOKEN": "${{ secrets.REVIEWS_CLAUDE_CODE_OAUTH_TOKEN }}"
}
},
"melodic-software/ci-workflows/.github/workflows/intake-label-needs-triage.yml@ab83b01273026ab5c23c6f3b40e946d97a863fa2": {
"routing": "runner-input",
"runnerInput": "runner",
Expand Down
13 changes: 13 additions & 0 deletions components/runner-policy/runner-policy.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10032,6 +10032,19 @@ test("the pr-review-cli contract at the v0.65.6 tag copies its v0.65.5 entry for
assert.equal(Object.keys(contracts).filter((k) => k.endsWith(`@${sha}`)).length, 1);
});

// v0.65.7 changes only what the hold step and the prompt do with holds
// (ci-workflows#880): hold-paths becomes extra security scrutiny in the
// prompt, not a hold, and a cost hold needs a real charge. The hold-paths
// input stays, and inputs, secrets and runner are unchanged, so the contract
// copies forward.
test("the pr-review-cli contract at the v0.65.7 tag copies its v0.65.6 entry forward verbatim", () => {
const contracts = BASE_POLICY.approvedReusableWorkflowContracts;
const key = (sha) => `melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@${sha}`;
const sha = "4c531cea137f5cbb38d4c132dbfa6e38f76fba7d";
assert.deepEqual(contracts[key(sha)], contracts[key("914264587c35692c15e05c965103426eec18d1f0")]);
assert.equal(Object.keys(contracts).filter((k) => k.endsWith(`@${sha}`)).length, 1);
});

// Convergence as a property, never as a hardcoded SHA. The daily
// claude-lanes-repin lane rewrites these components on every ci-workflows
// release, and a test naming one revision would go red by construction on
Expand Down
Loading