Repository navigation
feat(runner-policy): register ci-workflows v0.61.0 intake and review contracts - #843
Conversation
…contracts Carry the intake-triage, pr-review and pr-review-security contracts forward verbatim to the v0.61.0 tag (164c2809). The review workflows' new optional credential-name inputs are not passed by callers, so the allowed inputs stay as at v0.60.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Incremental review (e19b8d0, since 2aeadc6)I found nothing to report. The only change is in
Two things I could not check from this diff:
|
|
claude-security-review needs no new review of Security review: PR #843 (head 2aeadc6)No security findings. The PR adds three allowlist entries to
|
Replace "signed off by hand" with the actual approval: the owner approved on the condition that an independent security review of the v0.60.0 to v0.61.0 diff passed, and it did. Name the review-lane change as a workflow change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…contracts (#846) No related issue: registers the ci-workflows v0.62.0 contracts so claude-code-plugins can repin to it. ## Summary Registers the ci-workflows [v0.62.0](https://github.com/melodic-software/ci-workflows/releases/tag/v0.62.0) tag (`2fe38c031867900824c164e33a140a335ed9ecf0`) contracts for `intake-triage.yml`, `pr-review.yml` and `pr-review-security.yml`, in the same shape as [#843](#843) (v0.61.0) and [#842](#842) (v0.60.0). v0.62.0 adds only [ci-workflows#858](melodic-software/ci-workflows#858), which bounds the subprocess isolation install that timed out in two hosted security-review runs on claude-code-plugins. ## Fix - `components/runner-policy/policy.json`: three entries keyed `@2fe38c03…`, verbatim copies of the `@164c2809…` (v0.61.0) entries, each placed right after its v0.61.0 entry. - `components/runner-policy/README.md`: a v0.62.0 rollout paragraph after the v0.61.0 one. - `components/runner-policy/runner-policy.test.mjs`: `REPINE_LANE_SHA_V0_62_0` and a test that the three v0.62.0 contracts equal their v0.61.0 entries and that exactly three v0.62.0 contracts exist. ### Review basis `git diff 164c2809 2fe38c03` (ci-workflows compare API) touches four files: the three workflows and `.github/scripts/claude-lane-install-isolation.test.cjs`. No commit-relative action changes. - For each workflow, `yq` comparison of `.on` (`workflow_call` inputs and secrets), `.permissions`, each job's `permissions`, `runs-on` and `timeout-minutes`, the job list, and every step's `uses`: identical between the two tags. - The only hunks are the "Install subprocess isolation" step (`pr-review.yml`, `pr-review-security.yml`) and the two "Isolate the runner" steps (`intake-triage.yml`): apt is skipped when `bwrap` and `socat` are present, every `apt-get` call runs under `sudo timeout` against one shared deadline (50 s in the review lanes, 100 s in intake), and the final check requires both tools. ## Verification - `npm run test:runner-policy`: 335 tests, 335 pass, 0 fail, including `✔ the intake-triage and review contracts at the v0.62.0 tag copy their v0.61.0 entries forward verbatim`. - `npm run lint:runner-policy`: `Runner policy passed.` - Against the claude-code-plugins repin worktree (three callers moved to `@2fe38c03…`): its vendored policy gives three `runner-target-contract` failures (auto-approval declined); this branch's `runner-policy.mjs` and `policy.json` give `Runner policy passed.` - lefthook pre-commit (typos, editorconfig, markdownlint, gitleaks, biome): clean. - Left out: nothing. ## Related - [ci-workflows#858](melodic-software/ci-workflows#858), released in [v0.62.0](https://github.com/melodic-software/ci-workflows/releases/tag/v0.62.0). - The claude-code-plugins repin PR passes its runner-policy gate once this merges and syncs. - [#844](#844) (automated repin of the standards lane components to v0.61.0) is separate and not touched here. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-account-rotation#288
Summary
Registers the ci-workflows v0.61.0 tag (
164c2809f6150429b6f24d4a2777bb377af953d9) contracts forintake-triage.yml,pr-review.ymlandpr-review-security.yml, in the same shape as #842 did for v0.60.0.Fix
components/runner-policy/policy.json: three entries keyed@164c2809…, verbatim copies of the@82ca5ca…(v0.60.0) entries, each placed right after its v0.60.0 entry.components/runner-policy/README.md: a v0.61.0 sign-off paragraph after the v0.60.0 one.components/runner-policy/runner-policy.test.mjs:REPINE_LANE_SHA_V0_61_0and a test that the three v0.61.0 contracts equal their v0.60.0 entries and that exactly three v0.61.0 contracts exist.v0.61.0 is v0.60.0 plus melodic-software/ci-workflows#856 and melodic-software/ci-workflows#857 (
git log 82ca5ca..164c280). Ingit diff 82ca5ca 164c280:intake-triage.yml: no change toworkflow_callinputs, secrets, job permissions orruns-on; only steps, job outputs and the status job change.pr-review.ymlandpr-review-security.yml: each adds two optional inputs,credential-name(defaultCLAUDE_CODE_OAUTH_TOKEN) andfallback-credential-name(default empty). Callers do not pass them, soallowedInputsstays as at v0.60.0. Secrets, permissions and routing are unchanged.Verification
npm run test:runner-policy: 328 tests, 328 pass, 0 fail, including the new v0.61.0 test.credential-nameto the newpr-reviewentry made the new test fail (1 fail); the file was then restored.npm run lint:runner-policy:Runner policy passed.components/biome/biome.json) oncomponents/runner-policy, markdownlint, typos, editorconfig-checker and gitleaks: clean (lefthook pre-commit also passed).Related
🤖 Generated with Claude Code