Repository navigation
feat(runner-policy): approve the review lanes at ci-workflows v0.59.1 - #839
Closed
kyle-sexton wants to merge 1 commit into
Closed
kyle-sexton wants to merge 1 commit into
kyle-sexton wants to merge 1 commit into
Conversation
Copy the reviewed v0.55.0 (3a2c748) pr-review and pr-review-security contracts forward verbatim to v0.59.1 (8bd4d7f). Inputs, secrets and permissions are unchanged; the claude-code-action pin moves from v1.0.252 to v1.0.253 on the steps that receive the OAuth token (ci-workflows#838), which is why the gate declines auto-approval, and the findings count is raised to the summary's manifest flag lines (ci-workflows#848). Refs: melodic-software/claude-code-plugins#7110 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Superseded by #838 (the same two runner-policy entries at ci-workflows 8bd4d7f, already passed by Security & Cost and signed off). Closing so the two don't race; claude-code-plugins#8938 does the repin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: melodic-software/claude-code-plugins#7110
Summary
Registers ci-workflows
v0.59.1
(
8bd4d7f963a06627dd2d551ffcd8d9db5e6b881b) contracts forpr-review.ymlandpr-review-security.yml, soclaude-code-plugins#7110
can repin its hosted review lanes (
pr-review-hosted.yml,pr-review-security-hosted.yml) from v0.55.0 (3a2c748) to v0.59.1.The gate declines auto-approval because the credential surface changed: the
anthropics/claude-code-actionpin moves from v1.0.252 (f27be6b) tov1.0.253 (
5eb090f) on both review steps in each workflow, and those stepsreceive
CLAUDE_CODE_OAUTH_TOKEN(ci-workflows#838).
No
workflow_callinput or secret differs between v0.55.0 and v0.59.1.Owner review needed. Neither workflow is byte-identical to the SHA its
copied entry reviewed; the README rollout line says "sign-off pending".
Fix
components/runner-policy/policy.json: verbatim copies of the v0.55.0(
3a2c748) entries at8bd4d7f9, forpr-reviewandpr-review-security. No input, secret mapping, caller permission or routingis added or widened.
components/runner-policy/README.md: the v0.59.1 rollout line, sign-offpending.
components/runner-policy/runner-policy.test.mjs: a test that both v0.59.1entries equal their v0.55.0 entries and are the only two keys at that SHA.
Review basis
Git blob SHAs (
git rev-parse <sha>:.github/workflows/<file>):3a2c748(v0.55.0)8bd4d7f9(v0.59.1)pr-review.ymlc67ec82b4f3d4e44pr-review-security.yml1737f82d30b595b9git diff 3a2c748 8bd4d7fon each file shows exactly two changes, identicalin both files:
claude-code-actionv1.0.252 -> v1.0.253 on the primary review step andthe fallback review step (
pr-review.ymlL827 and L993;pr-review-security.ymlL638 and L795),ci-workflows#838.
manifest <field>: flaglines in the summary(ci-workflows#848).
Verification
npm run test:runner-policy: 326 pass, 0 fail, including✔ both review contracts at the v0.59.1 tag copy their v0.55.0 entries forward verbatim.npm run lint:runner-policy:Runner policy passed.callers repinned to
8bd4d7f9,node .github/standards/runner-policy/runner-policy.mjs --root .:with the vendored policy (before):
with this branch's
policy.jsoncopied in as the sync would (after):Runner policy passed.clean.
Related
(v0.58.0 intake contracts copied forward).
ci-workflows#838,
ci-workflows#848.
🤖 Generated with Claude Code