Skip to content

feat(github-actions-conventions): mark pr unblock in use and retire update, fix-ci, address-feedback #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 12, 2026
Merged

feat(github-actions-conventions): mark pr unblock in use and retire update, fix-ci, address-feedback #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions components/github-actions-conventions/naming-lint.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,7 @@ test("slot names the pull request pipeline model relies on parse as stage plus f
"pr-review-security",
"pr-verify",
"pr-explain",
"pr-address-feedback",
"pr-fix-ci",
"pr-update",
"pr-unblock",
"pr-merge",
"pr-automerge",
"post-merge-verify",
Expand All @@ -254,6 +252,9 @@ test("slot names the pull request pipeline model relies on parse as stage plus f
modifier: "go",
});
assert.equal(parseSlotName("pr-gatekeep", vocabulary).function, undefined);
for (const retired of ["pr-update", "pr-fix-ci", "pr-address-feedback"]) {
assert.equal(parseSlotName(retired, vocabulary).function, undefined, retired);
}
});

test("activity names follow the grammar", () => {
Expand Down
17 changes: 1 addition & 16 deletions components/github-actions-conventions/vocabulary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@
"plan": [],
"work": [{ "name": "respond-mention", "status": "in-use" }],
"pr": [
{
"name": "address-feedback",
"status": "reserved",
"purpose": "Respond to pull request review threads."
},
{ "name": "audit-workflows", "status": "in-use" },
{ "name": "automerge", "status": "in-use" },
{ "name": "bump-plugin-version", "status": "in-use" },
Expand All @@ -38,7 +33,6 @@
"status": "reserved",
"purpose": "Explain the pull request for human readers; runs alongside verify."
},
{ "name": "fix-ci", "status": "reserved", "purpose": "Repair failing CI." },
{ "name": "lint-dockerfile", "status": "in-use" },
{ "name": "merge", "status": "reserved", "purpose": "Merge the pull request." },
{
Expand All @@ -54,16 +48,7 @@
{ "name": "run-checks", "status": "in-use" },
{ "name": "scan-dependencies", "status": "in-use" },
{ "name": "test-windows", "status": "in-use" },
{
"name": "unblock",
"status": "reserved",
"purpose": "Assess a blocked pull request and take the action that unblocks it."
},
{
"name": "update",
"status": "reserved",
"purpose": "Bring the pull request branch up to date."
},
{ "name": "unblock", "status": "in-use" },
{ "name": "validate-onboard-catalog", "status": "in-use" },
{
"name": "verify",
Expand Down
Loading