Repository navigation
chore(ci): re-pin the review callers to ci-workflows v0.65.7 - #9803
Conversation
v0.65.7 (melodic-software/ci-workflows#880) holds a pull request only for a real-charge cost or a CRITICAL security finding: hold-paths now names files for extra security scrutiny and never holds by itself. The callers' hold-paths comment says so, and the lane test pins v0.65.7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. I read the whole 3-file diff and the PR context, and did not run the tests or the runner-policy check myself.
|
|
claude-security-review reviewed Security review of PR #9803: no security findings (0). I read the whole diff and the PR context. The PR re-pins two reusable-workflow callers from ci-workflows v0.65.6 to v0.65.7. It also updates the pin check in
critical-findings: 0 |
There was a problem hiding this comment.
The pr-verify verifier failed head 9c8f5561eb723ea1b08f855b2352f7153b5a426f. What it wrote, as data:
Summary: PR #9803 has no linked issue, so the spec is its own body. It re-pins both review callers from ci-workflows v0.65.6 to v0.65.7 and updates the test pin. The edits match the body and the test still checks them. The problem is what v0.65.7 does: a change to trusted-actors, CODEOWNERS, .gitmodules or check-trusted-trigger no longer holds the PR by itself, and spend from credits or subscription usage no longer triggers a cost hold. Both are holds the owner keeps, so loosening them is a blocking defect. The body cites owner decisions Q52 and Q53, but no trusted text available here records them.
- The PR body says the plugins/review code-review and security-review skills still list trust-gate and the broader cost class under 'Hold for a person' and leaves that as follow-up. That mismatch between the skill docs and the wrapper prompt should be tracked in an issue.
- `.github/workflows/pr-review-hosted.yml:169`: the re-pin to 4c531cea (v0.65.7) adopts upstream behavior under which a hold-paths match never holds by itself. This removes the automatic trust-gate hold on takeover-set paths (`.github/standards/trusted-actors/**`, `.github/actions/check-trusted-trigger/**`, `**/CODEOWNERS`, `**/.gitmodules`), leaving only whatever the model review decides. That loosens a hold the owner keeps. Fix: link an owner-written issue that records decisions Q52/Q53, or keep the v0.65.6 pin until one exists.
- `.github/workflows/pr-review-hosted.yml:192`: the rewritten hold-paths comment correctly describes the v0.65.7 behavior, and the input and its four globs are unchanged in both callers.
There was a problem hiding this comment.
The pr-verify verifier failed head 9c8f5561eb723ea1b08f855b2352f7153b5a426f. What it wrote about this file, as data:
- `.github/workflows/pr-review-security-hosted.yml:174`: the same re-pin narrows the cost hold to real charges, so prepaid-credit and subscription spend becomes a summary line instead of a hold. Cost holds belong to the owner. This needs owner authorization in trusted spec text, not only in the PR body's citation.
There was a problem hiding this comment.
The pr-verify verifier failed head 9c8f5561eb723ea1b08f855b2352f7153b5a426f. What it wrote about this file, as data:
- `scripts/ci-review-lanes.test.sh:79`: the pin assertion is updated to the v0.65.7 SHA and would fail if a caller drifted. Nothing here is wrong; it would need reverting only if the pin is reverted.
Refs: melodic-software/ci-workflows#880
Summary
Re-pins both review callers to ci-workflows v0.65.7 (
4c531cea137f5cbb38d4c132dbfa6e38f76fba7d), which carries owner decisions Q52 and Q53 (2026-10-24). A trusted-path match no longer holds a pull request by itself:hold-pathsnow names files the prompt sends to extra security scrutiny. A cost hold now needs a real charge. A spend from prepaid credits or subscription usage becomes a summary line, not a hold.Fix
pr-review-hosted.ymlandpr-review-security-hosted.yml:pr-review-cli.yml@4c531cea… # v0.65.7. Thehold-pathscomment now matches the new behavior. The input and its four globs are unchanged.scripts/ci-review-lanes.test.sh: pins v0.65.7, as chore(ci): re-pin the review callers to ci-workflows v0.65.6 #9660 did for v0.65.6.Verification
bash scripts/ci-review-lanes.test.sh: PASS=55 FAIL=0.node .github/standards/runner-policy/runner-policy.mjs --root <worktree>: Runner policy passed.actionlintpasses on both callers.scripts/check-affected.sh --tests: 10 passed, 4 skipped (CI only).Related
plugins/reviewcode-reviewandsecurity-reviewskills still listtrust-gateand the broadercostclass under "Hold for a person". The v0.65.7 wrapper prompt overrides them, and their recheck trigger has fired.🤖 Generated with Claude Code