Repository navigation
ci: repin the review lanes to ci-workflows v0.59.1 - #8938
Merged
Merged
Conversation
Move pr-review-hosted.yml and pr-review-security-hosted.yml from v0.55.0 (3a2c748) to v0.59.1 (8bd4d7f), which carries ci-workflows#848: the lane raises a findings count below the summary's manifest flag lines to that line count. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
added a commit
to melodic-software/standards
that referenced
this pull request
Oct 21, 2026
…838) Refs: melodic-software/claude-code-plugins#8938 ## Summary Registers ci-workflows [v0.59.1](https://github.com/melodic-software/ci-workflows/releases/tag/v0.59.1) (`8bd4d7f963a06627dd2d551ffcd8d9db5e6b881b`) contracts for `pr-review.yml` and `pr-review-security.yml`, so [claude-code-plugins#8938](melodic-software/claude-code-plugins#8938) can repin both review lanes from v0.55.0 (`3a2c748`) to v0.59.1. **Review: the GitHub Security & Cost session reviews this PR.** The gate cannot auto-approve these entries, so the copies rest on the review below. The README rollout line says "sign-off pending"; replace it with "signed off by hand on <date>" at sign-off. ## Fix - `components/runner-policy/policy.json`: verbatim copies of the v0.55.0 (`3a2c748`) entries at `8bd4d7f9`, for `pr-review` and `pr-review-security`. No input, secret mapping, caller permission or routing is added or widened. The policy entries do not record a credential-reference shape; the gate computes `credentialReferences` from the workflow, so no field changes there. - `components/runner-policy/README.md`: the v0.59.1 rollout line, sign-off pending. - `components/runner-policy/runner-policy.test.mjs`: a test that both v0.59.1 entries equal their v0.55.0 entries and are the only two keys at that SHA. ### Review basis Git blob SHAs (`git rev-parse <sha>:.github/workflows/<file>`): | File | `3a2c748` (v0.55.0) | `8bd4d7f9` (v0.59.1) | |---|---|---| | `pr-review.yml` | `c67ec82b` | `4f3d4e44` | | `pr-review-security.yml` | `1737f82d` | `30b595b9` | `git log 3a2c748f..8bd4d7f9` on the two files lists two commits. The full diff of each file has three hunks and none touches `on.workflow_call`, permissions or `runs-on`: 1. **Credential-bearing steps:** the review step and its fallback step, which receive `CLAUDE_CODE_OAUTH_TOKEN`, move `anthropics/claude-code-action` from `f27be6b65a4652f08a2ba3cff79114829b588967` (v1.0.252) to `5eb090f3c3afd701a0672cd32981197ca27688f6` (v1.0.253) ([ci-workflows#838](melodic-software/ci-workflows#838)). This is the `credentialReferences` diff the gate declines to auto-approve. 2. **Findings count:** the result step raises the review's findings count to the number of `manifest <field>: flag` lines in its summary when the count is lower ([ci-workflows#848](melodic-software/ci-workflows#848)). Model-free script logic, no credential. ## Verification - `npm run test:runner-policy`: 326 pass, 0 fail, including `✔ both review contracts at the v0.59.1 tag copy their v0.55.0 entries forward verbatim`. - `npm run lint:runner-policy`: `Runner policy passed.` - In the claude-code-plugins#8938 worktree (head `5fd71552`), `node .github/standards/runner-policy/runner-policy.mjs --root .`: - with its vendored policy (identical to standards `main`): two `runner-target-contract` failures, "auto-approval declined: credentialReferences changed since the previously reviewed melodic-software/ci-workflows@3a2c748f..." and the same for `pr-review-security.yml`; - with this branch's `policy.json` copied in: `Runner policy passed.` (file restored afterwards). - lefthook pre-commit (typos, editorconfig, markdownlint, gitleaks, biome): clean. ## Related - [claude-code-plugins#8938](melodic-software/claude-code-plugins#8938) passes its runner-policy gate once this merges and syncs. - [ci-workflows#838](melodic-software/ci-workflows#838): the claude-code-action bump. - [ci-workflows#848](melodic-software/ci-workflows#848): the findings-count fix (the v0.59.1 release commit). - Precedent: #832, #829, #828. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
marked this pull request as ready for review
October 21, 2026 21:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #8884
Refs: #7110
Summary
Repins the two locally owned AI review lane callers from ci-workflows v0.55.0 (
3a2c748) to v0.59.1 (8bd4d7f963a06627dd2d551ffcd8d9db5e6b881b). v0.59.1 carries the fix for ci-workflows#847 (#848): a lane whose reported findings count is below the number ofmanifest <field>: flaglines in its summary now has the count raised to that line count, so it can no longer report fewer findings than it flagged.Fix
.github/workflows/pr-review-hosted.yml:pr-review.yml@3a2c748…(v0.55.0) to@8bd4d7f…(v0.59.1)..github/workflows/pr-review-security-hosted.yml:pr-review-security.yml@3a2c748…(v0.55.0) to@8bd4d7f…(v0.59.1).What the reusables change between the tags (
git diff v0.55.0 v0.59.1 -- .github/workflows/pr-review.yml .github/workflows/pr-review-security.yml, 20 insertions, 6 deletions):on.workflow_callinputs, secrets, workflow or job permissions, or the tool allowlist, so the callers'with:,secrets:and grants stay as they are.anthropics/claude-code-actionmoves from v1.0.252 to v1.0.253 (ci-workflows#838) in the primary and fallback review steps of both reusables.Not changed here: the other
3a2c748/ v0.55.0 references are thecheck-managed-filescomposite pin inpr-check-managed-files-hosted.yml(sync-managed, not a caller of these reusables) and the contract keys in.github/standards/runner-policy/policy.json. No other caller ofpr-review.ymlorpr-review-security.ymlexists. No changelog fragment: precedent #7873 repinned the same two files without one.Verification
actionlint .github/workflows/pr-review-hosted.yml .github/workflows/pr-review-security-hosted.yml: no findings.node .github/standards/runner-policy/runner-policy.mjs --root .on the merged head 0097fc9:Runner policy passed.The v0.59.1 contracts came from standards#838 (S&C-passed, byte-identical to the v0.55.0 entries), synced here in chore: sync standards components #8939. The claude-code-action bump (feat(re-anchor): add scrutinize-dont-coast corrector #838 in ci-workflows) is what needed the reviewed contract, since each review step passesCLAUDE_CODE_OAUTH_TOKEN.Related
🤖 Generated with Claude Code