Repository navigation
fix(pr-pipeline): page through pr-verify runs in the lost-run reconciler - #8685
Conversation
The lane run listing read one page and failed when pr-verify had more than 100 runs in the lookback, so every scheduled run failed. It now pages up to 5 pages and still fails closed past that. The plan no longer says "nothing lost" when a listing failed, and the act step prints why it exits 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found in PR #8685 (head db7a569). The PR touches only the lost-run reconciler script, its test and a changelog fragment, and reads only GitHub API data. I checked these points:
The diff changes no instruction surface, so I did not apply the instruction-surface lens or consult the exception register. |
|
claude-review reviewed No findings. I read the diff, the PR context, and
One edge case is too minor to block. A listing of exactly 500 runs fills page 5 and |
No related issue: regression from #8562 reported by the GitHub Support hub
Summary
maintenance-reconcile-lost-runshas failed every scheduled run since#8562 merged. The plan step lists pr-verify runs for the last 24 hours
in one page and throws when
total_countis over 100. pr-verify now hasmore than 100 runs a day. The plan counted the failure but still
printed "nothing lost", and the act step exited 1 without saying why.
Fix
paginatehelper, up toLANE_RUN_PAGES(5 pages, 500 runs). Past the cap it still throws andcounts as a failure.
failed > 0.::error title=reconcile::line when it exits1, with the plan's listing failures and its own failed re-runs.
Verification
https://github.com/melodic-software/claude-code-plugins/actions/runs/39456940340
a 501-run listing is a failure and never "nothing lost"; act prints
the reason when the plan's
failed > 0. All three fail onorigin/main (29 pass, 3 fail) and pass here (32 of 32).
scripts/check-affected.sh --base origin/main --tests: 10 passed,4 skipped.
Related
🤖 Generated with Claude Code