Repository navigation
test: declare test scopes the selector missed - #8617
Conversation
Closes #8558 The selection audit on current main (shard 4/7) found five suites reading 182 files whose one-file diff did not select them. Each suite now declares those files in its `# test-scope:` header. The 28 gaps in the run the issue names were already fixed by #8411. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk7Lz7d2twxvA3LfRxnLkT
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found. The PR changes only |
|
claude-review reviewed No findings. The PR adds What I checked:
|
Refs: #8558
Summary
The 28 gaps in the run the issue names (39240292374, shard 4/7) were already fixed by #8411. Re-running the audit on current main (shard 4/7, 132 suites) found 182 gaps in five other suites.
Fix
Each suite declares the files it reads in a
# test-scope:header, as #8411 did; no selector logic changes.engine.test.sh(178 files): everyplugins/*/hooks/*file, whichtest_babysit_risk.pyscans, plus the convention, lib, fixture and workflow-helper files it reads.goimports-format.test.sh,markdown-check.test.sh: the plugin'splugin.json.setup-apply.test.sh:plugins/verification/lib/parse-concern-value.sh.read-lane-broker-check.test.sh:.github/standards/runner-policy/package.json.Verification
scripts/selection-audit.sh traceon the five suites: no gap.scripts/check-affected.sh --tests: 13 passed, 1 skipped.Related
#8411, #8410
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xk7Lz7d2twxvA3LfRxnLkT
Scope note: this covers audit shard 4 of 7 on today's main (182 gaps in 5 suites, 178 in
engine.test.sh); the 28 gaps in run 39240292374 were already fixed by #8411. The other six shards were not re-traced, so #8558 stays open until they are.