Repository navigation
docs(pr-pipeline): hold a lane PR on a not-verified item that can stop the lane - #7888
Conversation
…p the lane ci-workflows#755 shipped an intake author gate it listed as "unverified, fails closed"; it failed closed and skipped every intake run. A lane PR with such an item now waits for a live check, and the post-merge live check is a tracked issue rather than a PR-body line. Refs: #7886 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review needs no new review of |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
claude-review reviewed No findings. I reviewed the two-file docs change, which adds a rule under "Changing this config" in the pr-pipeline README and a 2.11.0 CHANGELOG entry.
|
melodic-automation-lanes
Bot
added
the
needs-human
|
The pr-unblock lane stopped on this pull request and needs a person: the merge stages a change under .github/workflows/, which the lane does not push.
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=7888 -f activity=resolve-conflicts |
Resolves the pr-pipeline CHANGELOG conflict by moving this entry to 2.10.0 above main's 2.9.1. Also rewords the rule so it no longer contradicts itself: check the item live before merging, and when only a merged run can exercise it, merge once a tracked issue names the check and its owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
removed
the
needs-human
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
melodic-automation-lanes
Bot
added
the
needs-human
|
The pr-unblock lane stopped on this pull request and needs a person: the merge stages a change under .github/workflows/, which the lane does not push.
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=7888 -f activity=resolve-conflicts |
Main took pr-pipeline 2.10.0, so this entry moves to 2.11.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
removed
the
needs-human
Refs: #7886
Summary
melodic-software/ci-workflows#755 changed the intake lane and listed its author gate as "unverified, fails closed" in the PR body. It merged unchecked, failed closed, and every intake run here skipped triage behind a green check (melodic-software/ci-workflows#772). The check was cheap before merge: an anonymous API read of any issue shows the
CONTRIBUTORassociation the webhook sends.Fix
One rule under Changing this config: a PR that changes a lane and lists a not-verified item that could stop the lane from running checks that item live before it merges. An item only a merged run can exercise, such as a changed workflow that runs from the base branch, merges only once a tracked issue names the check and its owner. A PR-body line does not count. The incident is cited as the observed-stumble evidence. CHANGELOG 2.11.0.
Verification
markdownlint-cli2on both files: 0 issues.scripts/check-affected.sh --tests: 6 passed, 3 skipped.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw