Repository navigation
fix(planning): bind wayfind SDK exclusion grader to one clause #6415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
388148a
fix(planning): bind wayfind SDK exclusion grader to one clause
kyle-sexton 0c34cdb
Merge remote-tracking branch 'origin/main' into fix/wayfind-sdk-grade…
kyle-sexton 9ee56c1
fix(planning): stop wayfind SDK grader at a coordinate "and" clause
kyle-sexton ce30391
fix(planning): end the exclusion-first SDK span at a comma-less "and"…
kyle-sexton deaa7f9
fix(planning): guard colon-form exclusion graders against re-inclusion
kyle-sexton d955692
fix(planning): stop the in-scope guard at the first comma in wayfind …
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "planning", | ||
| "version": "0.69.3", | ||
| "version": "0.69.4", | ||
| "userConfig": { | ||
| "surface": { | ||
| "type": "string", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
plugins/planning/evals/work-brief-respects-out-of-scope/samples/sdk-fenced-out.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| { | ||
| "pass": [ | ||
| {"answer": "Scope: partner client SDKs or libraries are out of scope; we publish a feed contract only.", "why": "exclusion stated"}, | ||
| {"answer": "Do not recommend building SDKs: the map excludes them, since we never ship client code.", "why": "exclusion stated before the term"} | ||
| {"answer": "Do not recommend building SDKs: the map excludes them, since we never ship client code.", "why": "exclusion stated before the term"}, | ||
| {"answer": "Out of scope: batch replay and the partner SDKs.", "why": "a colon label governs every item in its list"} | ||
| ], | ||
| "fail": [ | ||
| {"answer": "Evaluate which client SDKs (Python, Java, .NET) we should build to make adoption easiest.", "why": "tasks SDK work, no exclusion"}, | ||
| {"answer": "Find out what tooling and integration help each partner needs. Return findings per partner.", "why": "no exclusion at all"} | ||
| {"answer": "Find out what tooling and integration help each partner needs. Return findings per partner.", "why": "no exclusion at all"}, | ||
| {"answer": "Survey which client SDKs partners would adopt. Separately, the nightly batch job is out of scope and will not ship.", "why": "exclusion is about the batch job, in another sentence"}, | ||
| {"answer": "The nightly batch job is out of scope and the partner SDKs stay in scope.", "why": "exclusion first, coordinate clause without a comma keeps the SDK in scope"}, | ||
| {"answer": "Out of scope: the batch job and the partner SDKs stay in scope.", "why": "colon label, but the trailing clause keeps the SDK in scope"} | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
plugins/planning/evals/work-design-handoff-carries-map/samples/names-sdk-exclusion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "pass": [ | ||
| {"answer": "Settled: Debezium on Postgres logical replication. Out of scope: partner client SDKs or libraries; we only publish the feed contract.", "why": "exclusion governs the SDK in one clause"}, | ||
| {"answer": "Out of scope: batch replay and the partner SDKs.", "why": "a colon label governs every item in its list"} | ||
| ], | ||
| "fail": [ | ||
| {"answer": "Decision: webhook push or pulled cursor (#307). Partner SDKs remain open; separately, the nightly CSV retirement plan is out of scope.", "why": "exclusion is about something else, in another clause"}, | ||
| {"answer": "Decision: webhook push or pulled cursor (#307). Explore which client SDKs partners would want.", "why": "no exclusion"}, | ||
| {"answer": "Decision: webhook push or pulled cursor (#307). Partner SDKs stay open, and the nightly CSV retirement plan is out of scope.", "why": "coordinate clause excludes something else"}, | ||
| {"answer": "The nightly batch job is out of scope and the partner SDKs stay in scope.", "why": "exclusion first, coordinate clause without a comma keeps the SDK in scope"}, | ||
| {"answer": "Out of scope: the batch job and the partner SDKs stay in scope.", "why": "colon label, but the trailing clause keeps the SDK in scope"} | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
plugins/planning/evals/work-research-brief-carries-map/samples/names-sdk-exclusion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "pass": [ | ||
| {"answer": "Out of scope: partner client SDKs or libraries; we publish a feed contract only.", "why": "exclusion governs the SDK in one clause"}, | ||
| {"answer": "## Out-of-scope\n\n- Partner client SDKs or libraries: we publish a feed contract only and never ship client code", "why": "the map's own out-of-scope line"}, | ||
| {"answer": "Out of scope:\n- Replay windows\n- Partner client SDKs or libraries", "why": "SDK listed under an out-of-scope label"}, | ||
| {"answer": "Partner SDKs, client libraries, and plugins are out of scope.", "why": "serial-comma list ending in and stays one clause"}, | ||
| {"answer": "Out of scope: batch replay and the partner SDKs.", "why": "a colon label governs every item in its list"} | ||
| ], | ||
| "fail": [ | ||
| {"answer": "For Q3, given Debezium, recommend which partner SDKs we should build and ship.", "why": "tasks SDK work, no exclusion"}, | ||
| {"answer": "The partner SDK work remains open; separately, shipping the nightly batch job is explicitly out of scope and will not ship this quarter.", "why": "exclusion is about the batch job, in another clause"}, | ||
| {"answer": "Partner SDKs stay in scope. The nightly batch job is out of scope.", "why": "exclusion is in a different sentence"}, | ||
| {"answer": "We will build the partner SDKs, but the batch export is out of scope.", "why": "contrastive clause excludes something else"}, | ||
| {"answer": "Partner SDKs stay in scope, and the nightly batch job is out of scope.", "why": "coordinate clause excludes something else"}, | ||
| {"answer": "Partner SDKs stay in scope and the nightly batch job is out of scope.", "why": "coordinate clause without a comma excludes something else"}, | ||
| {"answer": "The nightly batch job is out of scope, and the partner SDKs stay in scope.", "why": "exclusion first, coordinate clause keeps the SDK in scope"}, | ||
| {"answer": "The nightly batch job is out of scope and the partner SDKs stay in scope.", "why": "exclusion first, coordinate clause without a comma keeps the SDK in scope"}, | ||
| {"answer": "Out of scope: the batch job and the partner SDKs stay in scope.", "why": "colon label, but the trailing clause keeps the SDK in scope"} | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.