Repository navigation
chore(pr-pipeline): turn off the agent App trust-path and exempt-author path holds #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b467d55
chore(pr-pipeline): turn off the agent App trust-path hold
kyle-sexton 0e8f68e
chore(pr-pipeline): turn off the exempt-author path hold behind path-…
kyle-sexton aa9b0c3
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton c0e2451
test(pr-pipeline): quote the hardened hold patterns with awk
kyle-sexton faa0cdd
docs(pr-pipeline): state that restoring the App hold also needs path-…
kyle-sexton 09700b8
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton 9aaf9eb
fix(pr-pipeline): keep ci-status's trust-path hold for Dependabot wit…
kyle-sexton 64965dd
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton 261eb21
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton 46f0ef5
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton 112d55d
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton 5bd52f1
docs(pr-pipeline): require one trust-path-hold entry and name all thr…
kyle-sexton a4ef96e
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton 6ade21d
Merge remote-tracking branch 'origin/main' into chore/drop-path-holds
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
.changes/pr-pipeline/drop-trust-path-hold-apps-5d1e7a20.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| bump: patch | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - The agent App trust-path hold is off (owner decision Q21, 2026-10-29: path holds stay off until | ||
| open issues and pull requests reach zero). `merge.trust-path-hold-apps` names only | ||
| `trust-path-hold-off[bot]`, a login no App holds, in place of `melodic-agent[bot]`, so neither | ||
| ci-status's inline hold nor ci-workflows' `pr-require-checks-trust-paths` (through the regenerated | ||
| `.github/trust-path-hold.json`) holds an agent App pull request for a person, except that both | ||
| still fail closed on a read they cannot finish: a pull request past 250 commits or 3000 files, or | ||
| a branch history past 2000 entries. The list keeps one entry because the shared workflow fails on | ||
| an empty one. Restoring both holds takes three steps: list `melodic-agent[bot]` again, set | ||
| `merge.diff-check.path-holds` true and run `scripts/sync-hold-floor.py`. Listing the App alone | ||
| restores only ci-workflows' hold, since ci-status's inline hold runs only while `path-holds` is | ||
| true. | ||
| - ci-status no longer holds a release-App or standards-sync-App pull request for changing a | ||
| trust-gate path, and still holds a Dependabot one, whose action-pin bumps bring in third-party | ||
| code (owner decisions Q21 and Q24). While `merge.diff-check.path-holds` is false, as this | ||
| repository sets the new key, `scripts/sync-hold-floor.py` writes a guard after ci-status's | ||
| exempt-author `hold_patterns` that empties the list for every author but Dependabot. Setting | ||
| it true holds all three again. These authors still get no review lane. |
5 changes: 5 additions & 0 deletions
5
.changes/source-control/drop-trust-path-hold-apps-0c4b9e61.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| bump: none | ||
| --- | ||
|
|
||
| Test-only: the merge-holds sync test checks that the trust-path hold's `apps` is non-empty instead of naming `melodic-agent[bot]`, and checks ci-status's exempt-author patterns as the generator writes them with path holds on and the Dependabot-only guard it adds with them off; the plugin ships no change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,6 @@ | |
| "docs/standards/*" | ||
| ], | ||
| "apps": [ | ||
| "melodic-agent[bot]" | ||
| "trust-path-hold-off[bot]" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.