Skip to content

fix(pr-pipeline): re-run a lost main-run review once from the lost-run reconciler #10996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 29, 2026
Merged

fix(pr-pipeline): re-run a lost main-run review once from the lost-run reconciler #10996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changes/pr-pipeline/fix-retry-lost-main-run-reviews-7c41e0b9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
bump: patch
---

### Fixed

- A pr-review-main run whose first attempt failed before any lane's verdict write started (every
credential leg stopped) is now re-run once, recorded, by the lost-run reconciler, as a lost
pr-verify run is, so a lane-source pull request no longer waits for its next push to be
reviewed from main.
365 changes: 365 additions & 0 deletions .github/scripts/maintenance-reconcile-lost-runs/fixtures/jobs-40892239796.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,365 @@
{
"jobs": [
{
"conclusion": "failure",
"id": 123511844321,
"name": "review (claude-security-review, security-review, review-security, CLAUDE_SECURITY_REVIEW_DISABLED)",
"status": "completed",
"steps": [
{
"conclusion": "success",
"name": "Set up job",
"number": 1,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check out the default branch tip",
"number": 2,
"status": "completed"
},
{
"conclusion": "success",
"name": "Set up Node",
"number": 3,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check the kill switch",
"number": 4,
"status": "completed"
},
{
"conclusion": "success",
"name": "Report the kill switch",
"number": 5,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check the trigger",
"number": 6,
"status": "completed"
},
{
"conclusion": "success",
"name": "Select a lane-source pull request",
"number": 7,
"status": "completed"
},
{
"conclusion": "success",
"name": "Write the diff",
"number": 8,
"status": "completed"
},
{
"conclusion": "success",
"name": "Select the trusted PR text",
"number": 9,
"status": "completed"
},
{
"conclusion": "success",
"name": "Copy the review criteria",
"number": 10,
"status": "completed"
},
{
"conclusion": "success",
"name": "Resolve the review's model",
"number": 11,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check the credential",
"number": 12,
"status": "completed"
},
{
"conclusion": "success",
"name": "Apply the Claude managed settings",
"number": 13,
"status": "completed"
},
{
"conclusion": "success",
"name": "Isolate the runner",
"number": 14,
"status": "completed"
},
{
"conclusion": "success",
"name": "Write the prompt and schema",
"number": 15,
"status": "completed"
},
{
"conclusion": "success",
"name": "Review the pull request",
"number": 16,
"status": "completed"
},
{
"conclusion": "success",
"name": "Report the review's outcome",
"number": 17,
"status": "completed"
},
{
"conclusion": "success",
"name": "Upload the sealed transcript",
"number": 18,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Write the verdict",
"number": 19,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Upload the verdict",
"number": 20,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Summarize the verdict",
"number": 21,
"status": "completed"
},
{
"conclusion": "success",
"name": "Log the API budget",
"number": 22,
"status": "completed"
},
{
"conclusion": "failure",
"name": "Fail without a verdict",
"number": 23,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Post Set up Node",
"number": 45,
"status": "completed"
},
{
"conclusion": "success",
"name": "Post Check out the default branch tip",
"number": 46,
"status": "completed"
},
{
"conclusion": "success",
"name": "Complete job",
"number": 47,
"status": "completed"
}
]
},
{
"conclusion": "failure",
"id": 123511844887,
"name": "review (claude-review, code-review, review-code, CLAUDE_REVIEW_DISABLED)",
"status": "completed",
"steps": [
{
"conclusion": "success",
"name": "Set up job",
"number": 1,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check out the default branch tip",
"number": 2,
"status": "completed"
},
{
"conclusion": "success",
"name": "Set up Node",
"number": 3,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check the kill switch",
"number": 4,
"status": "completed"
},
{
"conclusion": "success",
"name": "Report the kill switch",
"number": 5,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check the trigger",
"number": 6,
"status": "completed"
},
{
"conclusion": "success",
"name": "Select a lane-source pull request",
"number": 7,
"status": "completed"
},
{
"conclusion": "success",
"name": "Write the diff",
"number": 8,
"status": "completed"
},
{
"conclusion": "success",
"name": "Select the trusted PR text",
"number": 9,
"status": "completed"
},
{
"conclusion": "success",
"name": "Copy the review criteria",
"number": 10,
"status": "completed"
},
{
"conclusion": "success",
"name": "Resolve the review's model",
"number": 11,
"status": "completed"
},
{
"conclusion": "success",
"name": "Check the credential",
"number": 12,
"status": "completed"
},
{
"conclusion": "success",
"name": "Apply the Claude managed settings",
"number": 13,
"status": "completed"
},
{
"conclusion": "success",
"name": "Isolate the runner",
"number": 14,
"status": "completed"
},
{
"conclusion": "success",
"name": "Write the prompt and schema",
"number": 15,
"status": "completed"
},
{
"conclusion": "success",
"name": "Review the pull request",
"number": 16,
"status": "completed"
},
{
"conclusion": "success",
"name": "Report the review's outcome",
"number": 17,
"status": "completed"
},
{
"conclusion": "success",
"name": "Upload the sealed transcript",
"number": 18,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Write the verdict",
"number": 19,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Upload the verdict",
"number": 20,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Summarize the verdict",
"number": 21,
"status": "completed"
},
{
"conclusion": "success",
"name": "Log the API budget",
"number": 22,
"status": "completed"
},
{
"conclusion": "failure",
"name": "Fail without a verdict",
"number": 23,
"status": "completed"
},
{
"conclusion": "skipped",
"name": "Post Set up Node",
"number": 45,
"status": "completed"
},
{
"conclusion": "success",
"name": "Post Check out the default branch tip",
"number": 46,
"status": "completed"
},
{
"conclusion": "success",
"name": "Complete job",
"number": 47,
"status": "completed"
}
]
},
{
"conclusion": "success",
"id": 123512264027,
"name": "record",
"status": "completed",
"steps": [
{
"conclusion": "success",
"name": "Set up job",
"number": 1,
"status": "completed"
},
{
"conclusion": "success",
"name": "Download this run's verdicts",
"number": 2,
"status": "completed"
},
{
"conclusion": "success",
"name": "Record the counts",
"number": 3,
"status": "completed"
},
{
"conclusion": "success",
"name": "Complete job",
"number": 4,
"status": "completed"
}
]
}
],
"total_count": 3
}
Loading
Loading